[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4562: HBASE-27048 Server side scanner time limit should account for time in queue

[GitBox <gi...@apache.org>]

bbeaudreault commented on code in PR #4562:
URL: https://github.com/apache/hbase/pull/4562#discussion_r912360242


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:
##########
@@ -266,7 +266,7 @@ public class RSRpcServices extends HBaseRpcServicesBase<HRegionServer>
   /**
    * Default value of {@link RSRpcServices#REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA}
    */
-  private static final long DEFAULT_REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA = 10;
+  static final long DEFAULT_REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA = 10;

Review Comment:
   I agree. Only thing i could think of is maybe for like an s3-backed cluster where you know latency will be higher? 10ms may be too small and still timeout before starting. But that's really grasping.
   
   I'm happy to remove if that's what we want. @Apache9 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org