You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Lewuathe <gi...@git.apache.org> on 2015/01/09 14:33:29 UTC
[GitHub] storm pull request: [STORM-620] Duplicate maven plugin declaration
GitHub user Lewuathe opened a pull request:
https://github.com/apache/storm/pull/377
[STORM-620] Duplicate maven plugin declaration
Fix duplicate maven-javadoc-plugin declaration in pom.xml reporting section
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Lewuathe/storm duplicate-plugin-declaration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #377
----
commit f603a5e0c12fe902ac944a8e17ccc62b2d9f5ed8
Author: lewuathe <le...@me.com>
Date: 2015-01-09T13:27:03Z
[STORM-620] Duplicate maven plugin declaration
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-620] Duplicate maven plugin declaration
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/377#issuecomment-69365186
@Lewuathe very sorry I missed where it is in two places in the reporting section. You are 100% correct. +1 for mering this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-620] Duplicate maven plugin declaration
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-620] Duplicate maven plugin declaration
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/377#issuecomment-69364868
The javadoc plugin you removed is in the reporting section of the pom. That is used when running `mvn site` The other one is part of the dist profile, The dist profile is more or less dead code right now, but it's intention is to be run when we are building the binary and source distribution tar balls. I think both are needed if we ever get the dist profile working.
-1
If you disagree and can let me know why this is valid, I am happy to change my opinion. Otherwise please close this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---