You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by bouk <gi...@git.apache.org> on 2014/05/05 21:13:58 UTC
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
GitHub user bouk opened a pull request:
https://github.com/apache/spark/pull/651
Include the sbin/spark-config.sh in spark-executor
This is needed because broadcast values are broken on pyspark on Mesos, it tries to import pyspark but can't, as the PYTHONPATH is not set due to changes in ff5be9a4
https://issues.apache.org/jira/browse/SPARK-1725
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Shopify/spark include-spark-config-in-mesos-executor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/651.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #651
----
commit eedbbcc3d24a7ab94e5ae2fc89d9f08f8b69459c
Author: Bouke van der Bijl <bo...@gmail.com>
Date: 2014-05-05T19:08:25Z
Include the sbin/spark-config.sh in spark-executor
This is needed because broadcast values are broken on pyspark on Mesos,
it tries to import pyspark but can't.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42631303
I went ahead and merged this - thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by bouk <gi...@git.apache.org>.
Github user bouk commented on a diff in the pull request:
https://github.com/apache/spark/pull/651#discussion_r12453648
--- Diff: sbin/spark-executor ---
@@ -19,5 +19,10 @@
FWDIR="$(cd `dirname $0`/..; pwd)"
+sbin=`dirname "$0"`
+sbin=`cd "$sbin"; pwd`
+
+. "$sbin/spark-config.sh"
--- End diff --
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/651#discussion_r12450364
--- Diff: sbin/spark-executor ---
@@ -19,5 +19,10 @@
FWDIR="$(cd `dirname $0`/..; pwd)"
+sbin=`dirname "$0"`
--- End diff --
You can just re-use $FWDIR from above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/651#discussion_r12450389
--- Diff: sbin/spark-executor ---
@@ -19,5 +19,10 @@
FWDIR="$(cd `dirname $0`/..; pwd)"
+sbin=`dirname "$0"`
--- End diff --
I.e. `$FWDIR/sbin/spark-config.sh`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42451825
Mind creating a JIRA for this? If you could post the exception or issue that occurs it would be helfpul.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by bouk <gi...@git.apache.org>.
Github user bouk commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42455404
JIRA: https://issues.apache.org/jira/browse/SPARK-1725
The error that happens is `No module named pyspark`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42231191
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14675/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/651
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42608067
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42231190
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42611902
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/651#discussion_r12450552
--- Diff: sbin/spark-executor ---
@@ -19,5 +19,10 @@
FWDIR="$(cd `dirname $0`/..; pwd)"
+sbin=`dirname "$0"`
+sbin=`cd "$sbin"; pwd`
+
+. "$sbin/spark-config.sh"
--- End diff --
Hey actually - instead of doing this, do you mind just "inlining" the setting up of the PYTHONPATH into this file? `spark-config.sh` is intended to configure Spark's standalone daemons, it's not meant to be used at all in mesos mode. I realize the current approach fixes the problem, but it would be cleaner to just have the mesos executor setup $PYTHONPATH directly.
```
export PYTHONPATH=$FWDIR/python:$PYTHONPATH
export PYTHONPATH=$FWDIR/python/lib/py4j-0.8.1-src.zip:$PYTHONPATH
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42226665
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42226647
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42611903
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14823/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42615028
LGTM - @bouk did you test this new fix and make sure it works?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Include the sbin/spark-config.sh in spark-exec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/651#issuecomment-42608078
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---