You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by te...@apache.org on 2018/10/06 04:34:54 UTC
hbase git commit: HBASE-21272 Re-add assertions for RS Group admin
tests
Repository: hbase
Updated Branches:
refs/heads/branch-1 ae606c3d7 -> cbc2876ac
HBASE-21272 Re-add assertions for RS Group admin tests
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/cbc2876a
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/cbc2876a
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/cbc2876a
Branch: refs/heads/branch-1
Commit: cbc2876ac27c4e9f11744b58c72b892c35ef1edb
Parents: ae606c3
Author: tedyu <yu...@gmail.com>
Authored: Fri Oct 5 21:34:46 2018 -0700
Committer: tedyu <yu...@gmail.com>
Committed: Fri Oct 5 21:34:46 2018 -0700
----------------------------------------------------------------------
.../org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin1.java | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/cbc2876a/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin1.java
----------------------------------------------------------------------
diff --git a/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin1.java b/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin1.java
index 1bfc06b..ad25097 100644
--- a/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin1.java
+++ b/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin1.java
@@ -141,6 +141,8 @@ public class TestRSGroupsAdmin1 extends TestRSGroupsBase {
String groupName = tablePrefix+"_foo";
LOG.info("testNamespaceConstraint");
rsGroupAdmin.addRSGroup(groupName);
+ assertTrue(observer.preAddRSGroupCalled);
+ assertTrue(observer.postAddRSGroupCalled);
admin.createNamespace(NamespaceDescriptor.create(nsName)
.addConfiguration(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP, groupName)
.build());
@@ -161,6 +163,8 @@ public class TestRSGroupsAdmin1 extends TestRSGroupsBase {
//test add non-existent group
admin.deleteNamespace(nsName);
rsGroupAdmin.removeRSGroup(groupName);
+ assertTrue(observer.preRemoveRSGroupCalled);
+ assertTrue(observer.postRemoveRSGroupCalled);
try {
admin.createNamespace(NamespaceDescriptor.create(nsName)
.addConfiguration(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP, "foo")
@@ -431,4 +435,4 @@ public class TestRSGroupsAdmin1 extends TestRSGroupsBase {
initialize();
}
-}
\ No newline at end of file
+}