You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/16 16:29:19 UTC

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2696: sim/hcitty: add hcitty adapter

v01d commented on a change in pull request #2696:
URL: https://github.com/apache/incubator-nuttx/pull/2696#discussion_r558950888



##########
File path: arch/sim/Kconfig
##########
@@ -531,16 +531,31 @@ config SIM_QSPIFLASH_PAGESIZE
 		"wrap" causing the initial data sent to be overwritten.
 		This is consistent with standard SPI FLASH operation.
 
+choice
+	prompt "Simulated Prototype of HCI"
+	default SIM_HCISOCKET
+	depends on (HOST_LINUX && SIM_WALLTIME)
+
 config SIM_HCISOCKET
 	bool "Attach Host Bluetooth"
-	default false
-	depends on (WIRELESS_BLUETOOTH && HOST_LINUX && SIM_WALLTIME)
+	depends on WIRELESS_BLUETOOTH
+	---help---
+		Attached the local bluetooth device to the simulation
+		target via HCI_CHANNEL_USER. This gives NuttX full
+		control of the device, but is abstracted from the
+		physical interface which is still handled by Linux.

Review comment:
       this just repeats the help message of the other related option. please update it to reflect what it actually does different




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org