[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11184: Update the pinot tenants tables api to support returning broker tagged tables

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #11184:
URL: https://github.com/apache/pinot/pull/11184#discussion_r1277938379


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -84,6 +84,9 @@ public String forInstanceList() {
   public String forTablesFromTenant(String tenantName) {
     return StringUtil.join("/", _baseUrl, "tenants", tenantName, "tables");
   }
+  public String forTablesFromTenant(String tenantName, String componentType) {

Review Comment:
   (minor) add a new line before



##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##########
@@ -246,17 +246,27 @@ public SuccessResponse enableOrDisableTenant(
   @GET
   @Path("/tenants/{tenantName}/tables")
   @Produces(MediaType.APPLICATION_JSON)
-  @ApiOperation(value = "List tables on a a server tenant")
+  @ApiOperation(value = "List tables on a server or broker tenant")

Review Comment:
   Let's also update the javadoc above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org