You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Shreepadma Venugopalan <sh...@cloudera.com> on 2013/11/19 01:51:55 UTC
Review Request 15661: SENTRY-65: End to end test should set JDBC login
timeout
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15661/
-----------------------------------------------------------
Review request for sentry, Jarek Cecho and Prasad Mujumdar.
Bugs: SENTRY-65
https://issues.apache.org/jira/browse/SENTRY-65
Repository: sentry
Description
-------
Sets JDBC login timeout in the sentry hive end-end test infrastructure.
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/AbstractHiveServer.java 24a6fe9
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/EmbeddedHiveServer.java 853f75a
Diff: https://reviews.apache.org/r/15661/diff/
Testing
-------
mvn clean install -Pdownload-hadoop executed successfully.
Thanks,
Shreepadma Venugopalan
Re: Review Request 15661: SENTRY-65: End to end test should set JDBC login
timeout
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15661/#review29092
-----------------------------------------------------------
Ship it!
Thank you for the patch Shreepadma!
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/AbstractHiveServer.java
<https://reviews.apache.org/r/15661/#comment56219>
Nit: Please substitute the tabulator with spaces.
Jarcec
- Jarek Cecho
On Nov. 19, 2013, 12:51 a.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15661/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 12:51 a.m.)
>
>
> Review request for sentry, Jarek Cecho and Prasad Mujumdar.
>
>
> Bugs: SENTRY-65
> https://issues.apache.org/jira/browse/SENTRY-65
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sets JDBC login timeout in the sentry hive end-end test infrastructure.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/AbstractHiveServer.java 24a6fe9
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/EmbeddedHiveServer.java 853f75a
>
> Diff: https://reviews.apache.org/r/15661/diff/
>
>
> Testing
> -------
>
> mvn clean install -Pdownload-hadoop executed successfully.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>
Re: Review Request 15661: SENTRY-65: End to end test should set JDBC login
timeout
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15661/#review29094
-----------------------------------------------------------
Ship it!
Looks goood to me, will run tests and commit if they passes. Thank you for the hard work Shreepadma!
- Jarek Cecho
On Nov. 19, 2013, 1:37 a.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15661/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 1:37 a.m.)
>
>
> Review request for sentry, Jarek Cecho and Prasad Mujumdar.
>
>
> Bugs: SENTRY-65
> https://issues.apache.org/jira/browse/SENTRY-65
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sets JDBC login timeout in the sentry hive end-end test infrastructure.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/AbstractHiveServer.java 24a6fe9
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/EmbeddedHiveServer.java 853f75a
>
> Diff: https://reviews.apache.org/r/15661/diff/
>
>
> Testing
> -------
>
> mvn clean install -Pdownload-hadoop executed successfully.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>
Re: Review Request 15661: SENTRY-65: End to end test should set JDBC login
timeout
Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15661/
-----------------------------------------------------------
(Updated Nov. 19, 2013, 1:37 a.m.)
Review request for sentry, Jarek Cecho and Prasad Mujumdar.
Changes
-------
Removed trailing ws from AbstractHiveServer.java.
Bugs: SENTRY-65
https://issues.apache.org/jira/browse/SENTRY-65
Repository: sentry
Description
-------
Sets JDBC login timeout in the sentry hive end-end test infrastructure.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/AbstractHiveServer.java 24a6fe9
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/EmbeddedHiveServer.java 853f75a
Diff: https://reviews.apache.org/r/15661/diff/
Testing
-------
mvn clean install -Pdownload-hadoop executed successfully.
Thanks,
Shreepadma Venugopalan