You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "SergeiPatiakin (via GitHub)" <gi...@apache.org> on 2024/11/22 13:40:33 UTC
[PR] Add TableMetadataBuilder::assign_current_snapshot_id [iceberg-rust]
SergeiPatiakin opened a new pull request, #713:
URL: https://github.com/apache/iceberg-rust/pull/713
`TableMetadataBuilder::from_table_creation` initializes `current_snapshot_id` to `None`. This PR adds a builder method that allows different values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add TableMetadataBuilder::assign_current_snapshot_id [iceberg-rust]
Posted by "SergeiPatiakin (via GitHub)" <gi...@apache.org>.
SergeiPatiakin closed pull request #713: Add TableMetadataBuilder::assign_current_snapshot_id
URL: https://github.com/apache/iceberg-rust/pull/713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add TableMetadataBuilder::assign_current_snapshot_id [iceberg-rust]
Posted by "c-thiel (via GitHub)" <gi...@apache.org>.
c-thiel commented on PR #713:
URL: https://github.com/apache/iceberg-rust/pull/713#issuecomment-2493900023
Thanks @SergeiPatiakin for your PR!
Assigning the current snapshot id is a bit more complex than what you have in your PR.
Here is the extract from the spec: https://iceberg.apache.org/spec/#table-metadata-fields
`current-snapshot-id: ID of the current table snapshot; must be the same as the current ID of the main branch in refs.`
The logic you are looking for is already implemented in https://github.com/apache/iceberg-rust/pull/587 which is currently under review. I am optimistic that we can include it in the next release.
Could you check if https://github.com/apache/iceberg-rust/pull/587 serves your usecase? Check the `set_ref` method:
https://github.com/apache/iceberg-rust/pull/587/files#diff-464f76c3b76da41490c8fac47aa4aef4287fffdd0ca0766ae431c4829d59aa30R462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add TableMetadataBuilder::assign_current_snapshot_id [iceberg-rust]
Posted by "SergeiPatiakin (via GitHub)" <gi...@apache.org>.
SergeiPatiakin commented on PR #713:
URL: https://github.com/apache/iceberg-rust/pull/713#issuecomment-2493974787
Thanks! You are right, I think I'll be able to use `TableMetadataBuilder::set_ref` from https://github.com/apache/iceberg-rust/pull/587 . Closing this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org