You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by jm...@apache.org on 2005/12/06 01:52:23 UTC
svn commit: r354246 - /spamassassin/trunk/build/mkrules
Author: jm
Date: Mon Dec 5 16:52:20 2005
New Revision: 354246
URL: http://svn.apache.org/viewcvs?rev=354246&view=rev
Log:
fix 'make test' failures; always copy plugin perl modules
Modified:
spamassassin/trunk/build/mkrules
Modified: spamassassin/trunk/build/mkrules
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/build/mkrules?rev=354246&r1=354245&r2=354246&view=diff
==============================================================================
--- spamassassin/trunk/build/mkrules (original)
+++ spamassassin/trunk/build/mkrules Mon Dec 5 16:52:20 2005
@@ -188,7 +188,9 @@
# just copy the raw perl module over to the new area
# we can't really rename to avoid conflicts since the loadplugin lines
# are going to be all screwed up in that case.
- if (-e $entry->{t}) {
+ # jm: we always want to update the output file in case the input
+ # has been changed!
+ if (0 && -e $entry->{t}) {
warn "The perl module ".$entry->{t}." already exists, can't copy from ".$entry->{f}."\n";
}
else {
Re: svn commit: r354246 - /spamassassin/trunk/build/mkrules
Posted by Theo Van Dinter <fe...@apache.org>.
On Tue, Dec 06, 2005 at 12:52:23AM -0000, jm@apache.org wrote:
> - if (-e $entry->{t}) {
> + # jm: we always want to update the output file in case the input
> + # has been changed!
> + if (0 && -e $entry->{t}) {
> warn "The perl module ".$entry->{t}." already exists, can't copy from ".$entry->{f}."\n";
> }
> else {
The reason I did that was so in case multiple sandboxes had the same module
name, the first wouldn't get overwritten. But in that case something is going
to fail so I guess it doesn't matter.
--
Randomly Generated Tagline:
"Yea, it's gone." - Prof. Farr