You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/08 13:12:14 UTC

[GitHub] [spark] martin-g commented on pull request #35422: [SPARK-36061][K8S] Add Volcano feature step and enable user specified minimum resources

martin-g commented on pull request #35422:
URL: https://github.com/apache/spark/pull/35422#issuecomment-1032593354


   > It works with `maven`, but there are some failure on `sbt` build, `scala-maven-plugin` related exclude and dep configuration can't be recognize by `sbt`
   
   How about this:
   ```diff
   diff --git project/SparkBuild.scala project/SparkBuild.scala
   index 3d3a65f3d2..63ce6cbbf5 100644
   --- project/SparkBuild.scala
   +++ project/SparkBuild.scala
   @@ -429,6 +429,12 @@ object SparkBuild extends PomBuild {
        enable(SparkR.settings)(core)
      }
    
   +  if (!profiles.contains("volcano")) {
   +    enable(Seq(
   +      Compile / unmanagedSources / excludeFilter := HiddenFileFilter || "**/volcano/**/*.scala"
   +    ))(kubernetes)
   +  }
   +
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org