You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/27 02:33:41 UTC

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #144: Clean *.bdat and *.pdat on clean target

patacongo commented on a change in pull request #144: Clean *.bdat and *.pdat on clean target
URL: https://github.com/apache/incubator-nuttx-apps/pull/144#discussion_r399002070
 
 

 ##########
 File path: builtin/registry/Makefile
 ##########
 @@ -54,8 +54,8 @@ depend:
 
 clean:
 	$(call CLEAN)
-
-distclean: clean
 
 Review comment:
   > But *.pdat and *.bdat is generated by context target, the stuff generated by context is normally removed in distclean.
   
   Yes, that is the matching way to under to context target.  The basic idea is that each target in the make should have a matching target that undoes only the actions of that target.  Xiang is correct, make clean should not remove any products created by make context.
   
   There is a make clean_context or make distclean which are the appropriate places.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services