You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/25 06:26:10 UTC

[GitHub] [tvm] monklof commented on a change in pull request #7495: [Relay VM] VM Profiler Supports Profiling Instruction Stats

monklof commented on a change in pull request #7495:
URL: https://github.com/apache/tvm/pull/7495#discussion_r582574176



##########
File path: include/tvm/runtime/vm/bytecode.h
##########
@@ -26,6 +26,7 @@
 
 #include <tvm/runtime/data_type.h>
 #include <tvm/support/logging.h>
+#include <string>

Review comment:
       I think it's just fine since the result of InstructionStrRepr() is not a part of runtime's state, it's just used for profiling.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org