You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:43:39 UTC

[GitHub] [trafficcontrol] dpham692 opened a new issue #4915: Can update Delivery Service to use Topology when it's already assign to a Server.

dpham692 opened a new issue #4915:
URL: https://github.com/apache/trafficcontrol/issues/4915


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the
   [Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
   
   ## I'm submitting a ...
   <!-- delete all those that don't apply -->
   <!--- security vulnerability (STOP!! - see above)-->
   - [x]  bug report
   
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   - [ ]  CDN in a Box
   - [ ]  Documentation
   - [ ]  Grove
   - [ ]  Traffic Control Client
   - [ ]  Traffic Monitor
   - [x]  Traffic Ops
   - [ ]  Traffic Ops ORT
   - [x]  Traffic Portal
   - [ ]  Traffic Router
   - [ ]  Traffic Stats
   - [ ]  Traffic Vault
   - [ ]  unknown
   
   ## Current behavior:
   <!-- Describe how the bug manifests / how the current features are insufficient. -->
   Right now, user can update Delivery Service to use Topology when it's currently assign to a Servers.
   Step to generate error on TP:
   1. Create a Delivery Service, Server and Topology. Do not assign Topology to Delivery Service.
   2. Link Delivery Services to Server.
   3. Now, user can update Delivery Service to assign a Topology in the same CDN.
   
   ## Expected / new behavior:
   <!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
    TP shouldn't let user update Delivery Service to assign a Topology.
   ## Minimal reproduction of the problem with instructions:
   <!--
   If the current behavior is a bug or you can illustrate your feature request better with an example,
   please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
   -->
   
   ## Anything else:
   <!-- e.g. stacktraces, related issues, suggestions how to fix -->
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4915: Can update Delivery Service to use Topology when it's already assign to a Server.

Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #4915:
URL: https://github.com/apache/trafficcontrol/issues/4915#issuecomment-668070190


   This is fine actually @dpham692. We decided not to require the user to remove all assigned servers from a DS before assigning a topology. However, if a DS has BOTH a topology AND assigned servers, the topology will be used and the assigned servers will be ignored by Traffic Router.
   
   This approach allows a smoother transition to topologies.
   
   However, will all that said, the opposite is not allowed: a user cannot assign servers to a DS that has a topology assigned.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] dpham692 closed issue #4915: Can update Delivery Service to use Topology when it's already assign to a Server.

Posted by GitBox <gi...@apache.org>.
dpham692 closed issue #4915:
URL: https://github.com/apache/trafficcontrol/issues/4915


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 commented on issue #4915: Can update Delivery Service to use Topology when it's already assign to a Server.

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4915:
URL: https://github.com/apache/trafficcontrol/issues/4915#issuecomment-668070190


   This is fine actually @dpham692. We decided not to require the user to remove all assigned servers from a DS before assigning a topology. However, if a DS has BOTH a topology AND assigned servers, the topology will be used and the assigned servers will be ignored. 
   
   This approach allows a smoother transition to topologies.
   
   However, will all that said, the opposite is not allowed: a user cannot assign servers to a DS that has a topology assigned.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org