[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40349: [SPARK-42725][CONNECT][PYTHON] Make LiteralExpression support array params

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #40349:
URL: https://github.com/apache/spark/pull/40349#discussion_r1130826498


##########
python/pyspark/sql/connect/expressions.py:
##########
@@ -277,14 +281,26 @@ def _infer_type(cls, value: Any) -> DataType:
             return DateType()
         elif isinstance(value, datetime.timedelta):
             return DayTimeIntervalType()
-        else:
+        elif isinstance(value, np.generic):
             if isinstance(value, np.generic):

Review Comment:
   This seems duplicate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org