[jira] [Comment Edited] (HUDI-1496) Seek Error when querying MOR tables in GCP

["sivabalan narayanan (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HUDI-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260520#comment-17260520 ] 

sivabalan narayanan edited comment on HUDI-1496 at 1/7/21, 2:04 PM:
--------------------------------------------------------------------

[~vbalaji]: is this the fix you are suggesting
{code:java}
public static boolean isGCSFileSystem(FileSystem fs)
{
   return fs.getScheme().equals("gs");
}
{code}


was (Author: shivnarayan):
[~vbalaji]: is this the fix you are suggesting

```

public static boolean isGCSFileSystem(FileSystem fs) {
 return fs.getScheme().equals("gs");
}

```

> Seek Error when querying MOR tables in GCP
> ------------------------------------------
>
>                 Key: HUDI-1496
>                 URL: https://issues.apache.org/jira/browse/HUDI-1496
>             Project: Apache Hudi
>          Issue Type: Bug
>          Components: Common Core
>            Reporter: Balaji Varadarajan
>            Assignee: sivabalan narayanan
>            Priority: Major
>
> Context : [https://github.com/apache/hudi/issues/2367]
> FSUtils.isGCSInputStream is not catching all the cases when reading from GCS. IN some cases ([https://github.com/apache/hudi/blob/master/hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFileReader.java#L76),|https://github.com/apache/hudi/blob/master/hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFileReader.java#L76)] the condition in isGCSInputStream breaks
>  
> Instead of isGCSInputStream, we should detect GCSFileSystem by checking if the filesystem scheme is StorageSchemes.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)