[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7319: Fix unrealistic test variables in KafkaSupervisorTest and tidy up unused variable in checkpointing process

[GitBox <gi...@apache.org>]

surekhasaharan commented on a change in pull request #7319: Fix unrealistic test variables in KafkaSupervisorTest and tidy up unused variable in checkpointing process
URL: https://github.com/apache/incubator-druid/pull/7319#discussion_r284854753
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
 ##########
 @@ -338,19 +339,16 @@ public void handle()
     @Deprecated
     private final String baseSequenceName;
     private final SeekableStreamDataSourceMetadata<PartitionIdType, SequenceOffsetType> previousCheckpoint;
-    private final SeekableStreamDataSourceMetadata<PartitionIdType, SequenceOffsetType> currentCheckpoint;
 
-    public CheckpointNotice(
+    CheckpointNotice(
         @Nullable Integer nullableTaskGroupId,
         @Deprecated String baseSequenceName,
-        SeekableStreamDataSourceMetadata<PartitionIdType, SequenceOffsetType> previousCheckpoint,
-        SeekableStreamDataSourceMetadata<PartitionIdType, SequenceOffsetType> currentCheckpoint
+        SeekableStreamDataSourceMetadata<PartitionIdType, SequenceOffsetType> previousCheckpoint
 
 Review comment:
   should `previousCheckpoint` be renamed to `checkpointMetadata` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org