You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Thomas Weise <th...@apache.org> on 2019/01/24 15:40:11 UTC
Jenkins seed job fails
Processing DSL script job_PreCommit_Python.groovy
Processing DSL script job_PreCommit_Python_ValidatesRunner_Flink.groovy
java.lang.IllegalArgumentException:
beam_PreCommit_Python_PVR_Flink_Cron already exists
at hudson.model.Items.verifyItemDoesNotAlreadyExist(Items.java:641)
at hudson.model.AbstractItem.renameTo(AbstractItem.java:372)
at hudson.model.Job.renameTo(Job.java:653)
Can someone with perms please cleanup old jobs?
Thanks!
Re: Jenkins seed job fails
Posted by Thomas Weise <th...@apache.org>.
Thanks Scott.
I removed beam_PreCommit_Python_PVR_Flink_XXX and hopefully that will
unblock the seed job.
On Thu, Jan 24, 2019 at 1:05 PM Scott Wegner <sc...@apache.org> wrote:
> job_PreCommit_Python_ValidatesRunner_Flink.groovy has [1]:
>
> previousNames('beam_PostCommit_Python_VR_Flink')
>
> This is used by Jenkin to rename an existing job to the new name in order
> to retain history. In this case, both old a new Job names already exist, so
> it's failing:
>
> * https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/
> * https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/
>
> The jobs got into a similar mess before [2], and I believe it's due to
> having two different SeedJobs producing the same jobs.
>
> To unblock this case, I suggest manually
> deleting beam_PostCommit_Python_VR_Flink, as it appears the job history has
> already been migrated to _Cron. We should also consolidate the Seed Job
> functionality to a single job to prevent this from happening again.
>
> Note: I don't think it's correct to use the 'previousNames' feature with
> PrecommitJobBuilder as it creates three variants of the same job (normal,
> '_PR', '_Cron'); I'm not sure how Jenkins would handle the renaming;
> perhaps just use the first one.
>
> [1]
> https://github.com/apache/beam/blob/98952d20b5ad5e5cb74d53c08423429b20eb6523/.test-infra/jenkins/job_PreCommit_Python_ValidatesRunner_Flink.groovy#L35
> [2] https://issues.apache.org/jira/browse/BEAM-6250
>
> On Thu, Jan 24, 2019 at 12:09 PM Kenneth Knowles <kl...@google.com> wrote:
>
>> Jenkins has no understanding of this. Those are just different job names
>> that our scripts create. Is it a bug in PreCommitJobBuilder?
>>
>> Kenn
>>
>> On Thu, Jan 24, 2019 at 11:22 AM Ankur Goenka <go...@google.com> wrote:
>>
>>> It seems that the cron is not deleted if the job is deleted.
>>> I ran the seed job manually to test the new job which would have created
>>> the cron.
>>>
>>> I am not aware of jenkins internal but it will be great if we can clean
>>> up the cron on job deletion.
>>>
>>> On Thu, Jan 24, 2019 at 7:40 AM Thomas Weise <th...@apache.org> wrote:
>>>
>>>> Processing DSL script job_PreCommit_Python.groovy
>>>> Processing DSL script job_PreCommit_Python_ValidatesRunner_Flink.groovy
>>>> java.lang.IllegalArgumentException: beam_PreCommit_Python_PVR_Flink_Cron already exists
>>>> at hudson.model.Items.verifyItemDoesNotAlreadyExist(Items.java:641)
>>>> at hudson.model.AbstractItem.renameTo(AbstractItem.java:372)
>>>> at hudson.model.Job.renameTo(Job.java:653)
>>>>
>>>>
>>>> Can someone with perms please cleanup old jobs?
>>>>
>>>> Thanks!
>>>>
>>>>
>
> --
>
>
>
>
> Got feedback? tinyurl.com/swegner-feedback
>
Re: Jenkins seed job fails
Posted by Scott Wegner <sc...@apache.org>.
job_PreCommit_Python_ValidatesRunner_Flink.groovy has [1]:
previousNames('beam_PostCommit_Python_VR_Flink')
This is used by Jenkin to rename an existing job to the new name in order
to retain history. In this case, both old a new Job names already exist, so
it's failing:
* https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/
* https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/
The jobs got into a similar mess before [2], and I believe it's due to
having two different SeedJobs producing the same jobs.
To unblock this case, I suggest manually
deleting beam_PostCommit_Python_VR_Flink, as it appears the job history has
already been migrated to _Cron. We should also consolidate the Seed Job
functionality to a single job to prevent this from happening again.
Note: I don't think it's correct to use the 'previousNames' feature with
PrecommitJobBuilder as it creates three variants of the same job (normal,
'_PR', '_Cron'); I'm not sure how Jenkins would handle the renaming;
perhaps just use the first one.
[1]
https://github.com/apache/beam/blob/98952d20b5ad5e5cb74d53c08423429b20eb6523/.test-infra/jenkins/job_PreCommit_Python_ValidatesRunner_Flink.groovy#L35
[2] https://issues.apache.org/jira/browse/BEAM-6250
On Thu, Jan 24, 2019 at 12:09 PM Kenneth Knowles <kl...@google.com> wrote:
> Jenkins has no understanding of this. Those are just different job names
> that our scripts create. Is it a bug in PreCommitJobBuilder?
>
> Kenn
>
> On Thu, Jan 24, 2019 at 11:22 AM Ankur Goenka <go...@google.com> wrote:
>
>> It seems that the cron is not deleted if the job is deleted.
>> I ran the seed job manually to test the new job which would have created
>> the cron.
>>
>> I am not aware of jenkins internal but it will be great if we can clean
>> up the cron on job deletion.
>>
>> On Thu, Jan 24, 2019 at 7:40 AM Thomas Weise <th...@apache.org> wrote:
>>
>>> Processing DSL script job_PreCommit_Python.groovy
>>> Processing DSL script job_PreCommit_Python_ValidatesRunner_Flink.groovy
>>> java.lang.IllegalArgumentException: beam_PreCommit_Python_PVR_Flink_Cron already exists
>>> at hudson.model.Items.verifyItemDoesNotAlreadyExist(Items.java:641)
>>> at hudson.model.AbstractItem.renameTo(AbstractItem.java:372)
>>> at hudson.model.Job.renameTo(Job.java:653)
>>>
>>>
>>> Can someone with perms please cleanup old jobs?
>>>
>>> Thanks!
>>>
>>>
--
Got feedback? tinyurl.com/swegner-feedback
Re: Jenkins seed job fails
Posted by Kenneth Knowles <kl...@google.com>.
Jenkins has no understanding of this. Those are just different job names
that our scripts create. Is it a bug in PreCommitJobBuilder?
Kenn
On Thu, Jan 24, 2019 at 11:22 AM Ankur Goenka <go...@google.com> wrote:
> It seems that the cron is not deleted if the job is deleted.
> I ran the seed job manually to test the new job which would have created
> the cron.
>
> I am not aware of jenkins internal but it will be great if we can clean up
> the cron on job deletion.
>
> On Thu, Jan 24, 2019 at 7:40 AM Thomas Weise <th...@apache.org> wrote:
>
>> Processing DSL script job_PreCommit_Python.groovy
>> Processing DSL script job_PreCommit_Python_ValidatesRunner_Flink.groovy
>> java.lang.IllegalArgumentException: beam_PreCommit_Python_PVR_Flink_Cron already exists
>> at hudson.model.Items.verifyItemDoesNotAlreadyExist(Items.java:641)
>> at hudson.model.AbstractItem.renameTo(AbstractItem.java:372)
>> at hudson.model.Job.renameTo(Job.java:653)
>>
>>
>> Can someone with perms please cleanup old jobs?
>>
>> Thanks!
>>
>>
Re: Jenkins seed job fails
Posted by Ankur Goenka <go...@google.com>.
It seems that the cron is not deleted if the job is deleted.
I ran the seed job manually to test the new job which would have created
the cron.
I am not aware of jenkins internal but it will be great if we can clean up
the cron on job deletion.
On Thu, Jan 24, 2019 at 7:40 AM Thomas Weise <th...@apache.org> wrote:
> Processing DSL script job_PreCommit_Python.groovy
> Processing DSL script job_PreCommit_Python_ValidatesRunner_Flink.groovy
> java.lang.IllegalArgumentException: beam_PreCommit_Python_PVR_Flink_Cron already exists
> at hudson.model.Items.verifyItemDoesNotAlreadyExist(Items.java:641)
> at hudson.model.AbstractItem.renameTo(AbstractItem.java:372)
> at hudson.model.Job.renameTo(Job.java:653)
>
>
> Can someone with perms please cleanup old jobs?
>
> Thanks!
>
>