You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/27 02:03:30 UTC

[GitHub] sunjincheng121 commented on a change in pull request #7175: [FLINK-11004][Documentation] wrong ProcessWindowFunction.process argument in window document

sunjincheng121 commented on a change in pull request #7175: [FLINK-11004][Documentation] wrong ProcessWindowFunction.process argument in window document
URL: https://github.com/apache/flink/pull/7175#discussion_r236496272
 
 

 ##########
 File path: docs/dev/stream/operators/windows.md
 ##########
 @@ -836,12 +836,12 @@ input
   .reduce(
     (r1: SensorReading, r2: SensorReading) => { if (r1.value > r2.value) r2 else r1 },
     ( key: String,
-      window: TimeWindow,
+      context: Context,
 
 Review comment:
   Context defined in ProcessWindowFunction, so we should defined the type like:  `ProcessWindowFunction[_,_,_,TimeWindow]#Context` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services