You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "MOONSakura0614 (via GitHub)" <gi...@apache.org> on 2024/09/05 17:02:19 UTC
[PR] [INLONG-11022][SDK] Transform SQL support ParseUrl function [inlong]
MOONSakura0614 opened a new pull request, #11023:
URL: https://github.com/apache/inlong/pull/11023
<!-- Prepare a Pull Request
Change the title of pull request refer to the following example:
[INLONG-XYZ][Component] Title of the pull request
-->
<!-- Specify the issue this pull request going to fix.
The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)-->
Fixes #11022
### Motivation
Add a function class: ParseUrlFunction and its unit test.
- parse_url(string1, string2[, string3]): Returns the specified part from the URL. Valid values for string2 include ‘HOST’, ‘PATH’, ‘QUERY’, ‘REF’, ‘PROTOCOL’, ‘AUTHORITY’, ‘FILE’, and ‘USERINFO’. Returns NULL if any of arguments is NULL.
Also a value of a particular key in QUERY can be extracted by providing the key as the third argument string3.
<!--Explain here the context, and why you're making that change. What is the problem you're trying to solve.-->
### Modifications
<!--Describe the modifications you've done.-->
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [x] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11022][SDK] Transform SQL support ParseUrl function [inlong]
Posted by "MOONSakura0614 (via GitHub)" <gi...@apache.org>.
MOONSakura0614 commented on code in PR #11023:
URL: https://github.com/apache/inlong/pull/11023#discussion_r1746604974
##########
inlong-sdk/transform-sdk/src/main/java/org/apache/inlong/sdk/transform/process/function/ParseUrlFunction.java:
##########
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sdk.transform.process.function;
+
+import org.apache.inlong.sdk.transform.decode.SourceData;
+import org.apache.inlong.sdk.transform.process.Context;
+import org.apache.inlong.sdk.transform.process.operator.OperatorTools;
+import org.apache.inlong.sdk.transform.process.parser.ValueParser;
+
+import net.sf.jsqlparser.expression.Expression;
+import net.sf.jsqlparser.expression.Function;
+
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * ParseUrlFunction
+ * description: Returns the specified part from the URL. Valid values for string2
+ * include ‘HOST’, ‘PATH’, ‘QUERY’, ‘REF’, ‘PROTOCOL’, ‘AUTHORITY’, ‘FILE’, and ‘USERINFO’.
+ * Returns NULL if any of arguments is NULL.
+ * Also a value of a particular key in QUERY can be extracted by providing the key as the third argument string3.
+ */
+@TransformFunction(names = {"parse_url"})
+public class ParseUrlFunction implements ValueParser {
+
+ private ValueParser urlParser;
+ private ValueParser partParser;
+ private ValueParser keyParser;
+
+ public ParseUrlFunction(Function expr) {
+ List<Expression> params = expr.getParameters().getExpressions();
+ urlParser = OperatorTools.buildParser(params.get(0));
+ partParser = params.size() > 1 ? OperatorTools.buildParser(params.get(1)) : null;
+ keyParser = params.size() > 2 ? OperatorTools.buildParser(params.get(2)) : null;
+ }
+
+ @Override
+ public Object parse(SourceData sourceData, int rowIndex, Context context) {
+ if (urlParser == null || partParser == null) {
+ return null;
+ }
+ Object urlObj = urlParser.parse(sourceData, rowIndex, context);
+ Object partObj = partParser.parse(sourceData, rowIndex, context);
+ Object keyObj = keyParser != null ? keyParser.parse(sourceData, rowIndex, context) : null;
+
+ if (urlObj == null || partObj == null) {
+ return null;
+ }
+
+ String url = OperatorTools.parseString(urlObj);
+ String part = OperatorTools.parseString(partObj);
+ String key = keyObj != null ? OperatorTools.parseString(keyObj) : null;
+ if (keyParser != null && key == null) {
+ return null;
+ }
+
+ try {
+ URL netUrl = new URL(url);
+ Map<String, String> queryPairs = splitQuery(netUrl.getQuery());
+ if ("QUERY".equals(part)) {
+ if (key != null && queryPairs.containsKey(key)) {
+ return queryPairs.get(key);
+ }
+ return netUrl.getQuery();
+ } else {
+ switch (part) {
+ case "HOST":
+ return netUrl.getHost();
+ case "PATH":
+ return netUrl.getPath();
+ case "REF":
+ return netUrl.getRef();
+ case "PROTOCOL":
+ return netUrl.getProtocol();
+ case "AUTHORITY":
+ return netUrl.getAuthority();
+ case "FILE":
+ return netUrl.getFile();
+ case "USERINFO":
+ return netUrl.getUserInfo();
+ default:
+ return null;
+ }
+ }
+ } catch (MalformedURLException e) {
+ return null;
+ }
+ }
+
+ /**
+ * splitQuery
+ * @param query
+ * @return java.util.Map<java.lang.String,java.lang.String>
+ * @Description: Since Java 8 lacks URI decoding support available in Java 10+, URLDecoder.decode() cannot be used.
+ * Therefore, a manual decoding method is implemented to extract query parameters.
+ **/
+ private Map<String, String> splitQuery(String query) {
+ Map<String, String> queryPairs = new HashMap<>();
+ if (query != null) {
+ String[] pairs = query.split("&");
+ for (String pair : pairs) {
+ int idx = pair.indexOf("=");
+ if (idx != -1) { // skip if no "=" is found
+ queryPairs.put(manualDecode(pair.substring(0, idx)), manualDecode(pair.substring(idx + 1)));
+ }
+ }
+ }
+ return queryPairs;
+ }
+
+ private String manualDecode(String s) {
Review Comment:
It is not quite the same, but the idea is similar, it traverses the string to determine the special characters, but the manualDecode method is a simplified implementation, only focusing on % and not converting '+' to '=', etc., without considering all edge cases and the complexity of character sets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11022][SDK] Transform SQL support ParseUrl function [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on code in PR #11023:
URL: https://github.com/apache/inlong/pull/11023#discussion_r1746400196
##########
inlong-sdk/transform-sdk/src/main/java/org/apache/inlong/sdk/transform/process/function/ParseUrlFunction.java:
##########
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sdk.transform.process.function;
+
+import org.apache.inlong.sdk.transform.decode.SourceData;
+import org.apache.inlong.sdk.transform.process.Context;
+import org.apache.inlong.sdk.transform.process.operator.OperatorTools;
+import org.apache.inlong.sdk.transform.process.parser.ValueParser;
+
+import net.sf.jsqlparser.expression.Expression;
+import net.sf.jsqlparser.expression.Function;
+
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * ParseUrlFunction
+ * description: Returns the specified part from the URL. Valid values for string2
+ * include ‘HOST’, ‘PATH’, ‘QUERY’, ‘REF’, ‘PROTOCOL’, ‘AUTHORITY’, ‘FILE’, and ‘USERINFO’.
+ * Returns NULL if any of arguments is NULL.
+ * Also a value of a particular key in QUERY can be extracted by providing the key as the third argument string3.
+ */
+@TransformFunction(names = {"parse_url"})
+public class ParseUrlFunction implements ValueParser {
+
+ private ValueParser urlParser;
+ private ValueParser partParser;
+ private ValueParser keyParser;
+
+ public ParseUrlFunction(Function expr) {
+ List<Expression> params = expr.getParameters().getExpressions();
+ urlParser = OperatorTools.buildParser(params.get(0));
+ partParser = params.size() > 1 ? OperatorTools.buildParser(params.get(1)) : null;
+ keyParser = params.size() > 2 ? OperatorTools.buildParser(params.get(2)) : null;
+ }
+
+ @Override
+ public Object parse(SourceData sourceData, int rowIndex, Context context) {
+ if (urlParser == null || partParser == null) {
+ return null;
+ }
+ Object urlObj = urlParser.parse(sourceData, rowIndex, context);
+ Object partObj = partParser.parse(sourceData, rowIndex, context);
+ Object keyObj = keyParser != null ? keyParser.parse(sourceData, rowIndex, context) : null;
+
+ if (urlObj == null || partObj == null) {
+ return null;
+ }
+
+ String url = OperatorTools.parseString(urlObj);
+ String part = OperatorTools.parseString(partObj);
+ String key = keyObj != null ? OperatorTools.parseString(keyObj) : null;
+ if (keyParser != null && key == null) {
+ return null;
+ }
+
+ try {
+ URL netUrl = new URL(url);
+ Map<String, String> queryPairs = splitQuery(netUrl.getQuery());
+ if ("QUERY".equals(part)) {
+ if (key != null && queryPairs.containsKey(key)) {
+ return queryPairs.get(key);
+ }
+ return netUrl.getQuery();
+ } else {
+ switch (part) {
+ case "HOST":
+ return netUrl.getHost();
+ case "PATH":
+ return netUrl.getPath();
+ case "REF":
+ return netUrl.getRef();
+ case "PROTOCOL":
+ return netUrl.getProtocol();
+ case "AUTHORITY":
+ return netUrl.getAuthority();
+ case "FILE":
+ return netUrl.getFile();
+ case "USERINFO":
+ return netUrl.getUserInfo();
+ default:
+ return null;
+ }
+ }
+ } catch (MalformedURLException e) {
+ return null;
+ }
+ }
+
+ /**
+ * splitQuery
+ * @param query
+ * @return java.util.Map<java.lang.String,java.lang.String>
+ * @Description: Since Java 8 lacks URI decoding support available in Java 10+, URLDecoder.decode() cannot be used.
+ * Therefore, a manual decoding method is implemented to extract query parameters.
+ **/
+ private Map<String, String> splitQuery(String query) {
+ Map<String, String> queryPairs = new HashMap<>();
+ if (query != null) {
+ String[] pairs = query.split("&");
+ for (String pair : pairs) {
+ int idx = pair.indexOf("=");
+ if (idx != -1) { // skip if no "=" is found
+ queryPairs.put(manualDecode(pair.substring(0, idx)), manualDecode(pair.substring(idx + 1)));
+ }
+ }
+ }
+ return queryPairs;
+ }
+
+ private String manualDecode(String s) {
Review Comment:
Is this method the same as `URLDecoder.decode()` from JDK 10+?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11022][SDK] Transform SQL support ParseUrl function [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang merged PR #11023:
URL: https://github.com/apache/inlong/pull/11023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org