You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@felix.apache.org by GitBox <gi...@apache.org> on 2022/09/23 13:22:39 UTC

[GitHub] [felix-dev] amitjoy commented on a diff in pull request #172: [FELIX-6564] Fixed NPE while retrieving component descriptions from SCR

amitjoy commented on code in PR #172:
URL: https://github.com/apache/felix-dev/pull/172#discussion_r978659010


##########
scr/src/main/java/org/apache/felix/scr/impl/runtime/ServiceComponentRuntimeImpl.java:
##########
@@ -117,6 +117,10 @@ public Collection<ComponentConfigurationDTO> getComponentConfigurationDTOs(Compo
         try
         {
             ComponentHolder<?> holder = getHolderFromDescription( description);
+            // the holder can also be null if the associated component is deregistered

Review Comment:
   Thanks a lot for the detailed feedback 👍  I have updated the MR with the required changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org