[GitHub] spark pull request #13454: [SPARK-15714][CORE] Fix flaky o.a.s.scheduler.Bla...

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13454#discussion_r65626471
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/SchedulerIntegrationSuite.scala ---
    @@ -307,10 +312,19 @@ private[spark] abstract class MockBackend(
        */
       override def reviveOffers(): Unit = {
         val offers: Seq[WorkerOffer] = generateOffers()
    -    val newTasks = taskScheduler.resourceOffers(offers).flatten
    +    val newTaskDescriptions = taskScheduler.resourceOffers(offers).flatten
    +    // get the task now, since that requires a lock on TaskSchedulerImpl, to prevent individual
    +    // tests for introducing a race if they need it
    --- End diff --
    
    s/for/from


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org