You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/23 00:47:11 UTC

[GitHub] [hudi] garyli1019 opened a new pull request #1862: [HUDI-1120] Support spotless for scala

garyli1019 opened a new pull request #1862:
URL: https://github.com/apache/hudi/pull/1862


   ## What is the purpose of the pull request
   
   Support spotless for Scala.
   
   ## Brief change log
   
     - *Add initial support for spotless with scalafmt*
   
   ## Verify this pull request
   
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] garyli1019 edited a comment on pull request #1862: [HUDI-1120] Support spotless for scala

Posted by GitBox <gi...@apache.org>.
garyli1019 edited a comment on pull request #1862:
URL: https://github.com/apache/hudi/pull/1862#issuecomment-662768085


   @leesf Can we bring back the scala support for spotless first? Right now looks like we don't have any check for scala code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] garyli1019 commented on a change in pull request #1862: [HUDI-1120] Support spotless for scala

Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #1862:
URL: https://github.com/apache/hudi/pull/1862#discussion_r459865469



##########
File path: pom.xml
##########
@@ -181,21 +181,26 @@
           </execution>
         </executions>
       </plugin>
-<!--
-      See https://jira.apache.org/jira/browse/HUDI-304
+
+<!--  See https://jira.apache.org/jira/browse/HUDI-304-->
       <plugin>
         <groupId>com.diffplug.spotless</groupId>

Review comment:
       Thanks for reviewing. spotless and scalafmt both using Apache 2.0 License so I think it will be fine. Maybe it was on the Java side?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] leesf commented on a change in pull request #1862: [HUDI-1120] Support spotless for scala

Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #1862:
URL: https://github.com/apache/hudi/pull/1862#discussion_r459863820



##########
File path: pom.xml
##########
@@ -181,21 +181,26 @@
           </execution>
         </executions>
       </plugin>
-<!--
-      See https://jira.apache.org/jira/browse/HUDI-304
+
+<!--  See https://jira.apache.org/jira/browse/HUDI-304-->
       <plugin>
         <groupId>com.diffplug.spotless</groupId>

Review comment:
       this plugin has some licensing issues before, not sure if it is ok to bring back now cc @bvaradar 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] garyli1019 commented on a change in pull request #1862: [HUDI-1120] Support spotless for scala

Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #1862:
URL: https://github.com/apache/hudi/pull/1862#discussion_r459162879



##########
File path: style/scalafmt.conf
##########
@@ -0,0 +1,52 @@
+
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+# limitations under the License.
+
+# scalafmt is a code formatter for Scala
+# Documentation: https://scalameta.org/scalafmt/

Review comment:
       please check the configuration here if interested: https://scalameta.org/scalafmt/docs/configuration.html




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #1862: WIP[HUDI-1120] Support spotless for scala

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1862:
URL: https://github.com/apache/hudi/pull/1862#issuecomment-774541595


   @xushiyan can we create an umbrella ticket for all the spotless, code cleanup task (ofc after you free up from CI efforts)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #1862: WIP[HUDI-1120] Support spotless for scala

Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1862:
URL: https://github.com/apache/hudi/pull/1862#issuecomment-774590942


   @vinothchandar the ticket is already there
   https://issues.apache.org/jira/browse/HUDI-1237


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] garyli1019 commented on pull request #1862: [HUDI-1120] Support spotless for scala

Posted by GitBox <gi...@apache.org>.
garyli1019 commented on pull request #1862:
URL: https://github.com/apache/hudi/pull/1862#issuecomment-662768085


   @leesf Can we bring back the scala support for spotless first? Right now looks like to don't have any check for scala code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org