[GitHub] [shardingsphere] tuichenchuxin commented on a diff in pull request #26305: Bugfix encryption distinct select bug

["tuichenchuxin (via GitHub)" <gi...@apache.org>]

tuichenchuxin commented on code in PR #26305:
URL: https://github.com/apache/shardingsphere/pull/26305#discussion_r1234640848


##########
features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/EncryptOrderByItemTokenGenerator.java:
##########
@@ -101,7 +101,9 @@ private Collection<OrderByItem> getOrderByItems(final SQLStatementContext sqlSta
         }
         Collection<OrderByItem> result = new LinkedList<>();
         SelectStatementContext statementContext = (SelectStatementContext) sqlStatementContext;
-        result.addAll(statementContext.getOrderByContext().getItems());
+        if (!statementContext.getOrderByContext().isGenerated()) {

Review Comment:
   Why we remove generated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org