You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "crepererum (via GitHub)" <gi...@apache.org> on 2023/05/30 12:12:13 UTC

[GitHub] [arrow-datafusion] crepererum commented on pull request #6449: Propagate panics

crepererum commented on PR #6449:
URL: https://github.com/apache/arrow-datafusion/pull/6449#issuecomment-1568326616

   Good fix and test, thank you. Could you test+fix `datafusion/core/src/physical_plan/repartition/mod.rs` as well and remove `AbortOnDropMany` from the code base so that nobody introduces the same bug again? If you don't have the time/resources, just write a ticket and someone else will (hopefully) pick it up.
   
   Short side note on `JoinSet`: IIRC this is a rather recent (1y or so) addition to tokio and wasn't available when the abortion bug was fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org