You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/07 08:07:30 UTC

[GitHub] [incubator-nuttx] yamt commented on pull request #5997: fs/mmap/msync: support msync and fix minor issue

yamt commented on PR #5997:
URL: https://github.com/apache/incubator-nuttx/pull/5997#issuecomment-1091257219

   * don't you need to distinguish MAP_SHARED/MAP_PRIVATE?
   * don't you need some reference counting on the file?
   * i guess mmap should not modify file offset. (not specific to this PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org