You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Manu Zhang (JIRA)" <ji...@apache.org> on 2018/10/04 03:00:00 UTC

[jira] [Commented] (BEAM-5620) Some tests use assertItemsEqual method, not available in Python 3

    [ https://issues.apache.org/jira/browse/BEAM-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637744#comment-16637744 ] 

Manu Zhang commented on BEAM-5620:
----------------------------------

[~tvalentyn], I've seen fixes like [https://github.com/apache/beam/blob/c34c367f5da6f9bef8a46471195470923a201af9/sdks/python/apache_beam/coders/coders_test_common.py#L61] where `assertItemsEqual` is assigned to `assertCountEqual` on Python 2. Do you think it's a good idea to put it in a subclass of `TestCase` ?

> Some tests use assertItemsEqual method, not available in Python 3
> -----------------------------------------------------------------
>
>                 Key: BEAM-5620
>                 URL: https://issues.apache.org/jira/browse/BEAM-5620
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Valentyn Tymofieiev
>            Priority: Major
>
> See: https://github.com/apache/beam/search?q=assertItemsEqual&unscoped_q=assertItemsEqual



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)