You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "David Crossley (JIRA)" <ji...@apache.org> on 2005/08/18 16:13:57 UTC

[jira] Commented: (FOR-603) How to become a Forrest Committer

    [ http://issues.apache.org/jira/browse/FOR-603?page=comments#action_12319173 ] 

David Crossley commented on FOR-603:
------------------------------------

Youch, i pressed the worng button and deleted it. Could you please re-attach. Whitespace inconsistencies cause havoc. Could we discuss that on the dev list please.

> How to become a Forrest Committer
> ---------------------------------
>
>          Key: FOR-603
>          URL: http://issues.apache.org/jira/browse/FOR-603
>      Project: Forrest
>         Type: Improvement
>   Components: Documentation and website
>     Reporter: Addison Berry
>     Priority: Minor
>      Fix For: 0.8-dev
>  Attachments: com.aart, committer.xml
>
> Issue brought up on the mail list at http://marc.theaimsgroup.com/?l=forrest-dev&amp;m=112239074108858&amp;w=2 re: creating documentation on becoming a committer in Forrest.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


whitespace issues

Posted by David Crossley <cr...@apache.org>.
Addi wrote:
> >David Crossley commented on FOR-603:
> >------------------------------------
> >
> >Youch, i pressed the worng button and deleted it. Could you please 
> >re-attach. Whitespace inconsistencies cause havoc. Could we discuss that 
> >on the dev list please.
>
> Geez, OK I finally figured out my whitespace issue.  I had changed my 
> editor to match the document (2 soft space tabs and 80 char hard wrap) 
> but it was also set to remove trailing whitespaces on save and most of 
> that file had trailing whitespaces so the whole thing got screwy.  I 
> changed that setting and redid the diff and it looks much better now.  
> Sorry I have been submitting such crazy patches, but I think I have it 
> worked out now.  I will put the new diff up now.

The state of our svn is partly to blame. We need a big
whitespace cleanup. There is a mixture of tabs and spaces
and there is trailing whitespace. We should clean it up
a section at a time, when people are not working on
that section.

-David

Re: [jira] Commented: (FOR-603) How to become a Forrest Committer

Posted by Addi <ad...@rocktreesky.com>.
David Crossley (JIRA) wrote:

>    [ http://issues.apache.org/jira/browse/FOR-603?page=comments#action_12319173 ] 
>
>David Crossley commented on FOR-603:
>------------------------------------
>
>Youch, i pressed the worng button and deleted it. Could you please re-attach. Whitespace inconsistencies cause havoc. Could we discuss that on the dev list please.
>  
>
Geez, OK I finally figured out my whitespace issue.  I had changed my 
editor to match the document (2 soft space tabs and 80 char hard wrap) 
but it was also set to remove trailing whitespaces on save and most of 
that file had trailing whitespaces so the whole thing got screwy.  I 
changed that setting and redid the diff and it looks much better now.  
Sorry I have been submitting such crazy patches, but I think I have it 
worked out now.  I will put the new diff up now.

- Addi

>>How to become a Forrest Committer
>>---------------------------------
>>
>>         Key: FOR-603
>>         URL: http://issues.apache.org/jira/browse/FOR-603
>>     Project: Forrest
>>        Type: Improvement
>>  Components: Documentation and website
>>    Reporter: Addison Berry
>>    Priority: Minor
>>     Fix For: 0.8-dev
>> Attachments: com.aart, committer.xml
>>
>>Issue brought up on the mail list at http://marc.theaimsgroup.com/?l=forrest-dev&amp;m=112239074108858&amp;w=2 re: creating documentation on becoming a committer in Forrest.
>>    
>>
>
>  
>



Re: [jira] Commented: (FOR-603) How to become a Forrest Committer

Posted by David Crossley <cr...@apache.org>.
Addison, did you catch my faux pas.

-David

David Crossley (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/FOR-603?page=comments#action_12319173 ] 
> 
> David Crossley commented on FOR-603:
> ------------------------------------
> 
> Youch, i pressed the worng button and deleted it. Could you please re-attach. Whitespace inconsistencies cause havoc. Could we discuss that on the dev list please.
> 
> > How to become a Forrest Committer
> > ---------------------------------
> >
> >          Key: FOR-603
> >          URL: http://issues.apache.org/jira/browse/FOR-603
> >      Project: Forrest
> >         Type: Improvement
> >   Components: Documentation and website
> >     Reporter: Addison Berry
> >     Priority: Minor
> >      Fix For: 0.8-dev
> >  Attachments: com.aart, committer.xml
> >
> > Issue brought up on the mail list at http://marc.theaimsgroup.com/?l=forrest-dev&amp;m=112239074108858&amp;w=2 re: creating documentation on becoming a committer in Forrest.
> 
> -- 
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira