You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "nikunjbhartia (via GitHub)" <gi...@apache.org> on 2024/10/21 17:01:43 UTC
[PR] add back ticks for $BQ_DATASET in test.sql files [datasketches-bigquery]
nikunjbhartia opened a new pull request, #81:
URL: https://github.com/apache/datasketches-bigquery/pull/81
1) In *tests.sql files: $BQ_DATASET -> `$BQ_DATASET` to ensure queries don't fails if dataset contains special characters
2) In substitute_and_run.sh: `bq query ..` -> `bq --project_id $BQ_PROJECT query ..`
Since *_test.sql files don't have project qualified datasets, above flag in bq cli ensures all test queries are run in the project where UDFs are created, otherwise they might default to the project defined in local gcloud configs
3) updated Makefile `test` task to continue execution on error by adding `-`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] add back ticks for $BQ_DATASET in test.sql files [datasketches-bigquery]
Posted by "AlexanderSaydakov (via GitHub)" <gi...@apache.org>.
AlexanderSaydakov merged PR #81:
URL: https://github.com/apache/datasketches-bigquery/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org