[GitHub] [hive] veghlaci05 commented on a diff in pull request #4114: HIVE-27135: Cleaner fails with FileNotFoundException

["veghlaci05 (via GitHub)" <gi...@apache.org>]

veghlaci05 commented on code in PR #4114:
URL: https://github.com/apache/hive/pull/4114#discussion_r1135504270


##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -1538,9 +1537,9 @@ private static HdfsDirSnapshot addToSnapshot(Map<Path, HdfsDirSnapshot> dirToSna
   public static Map<Path, HdfsDirSnapshot> getHdfsDirSnapshots(final FileSystem fs, final Path path)

Review Comment:
   @mdayakar I agree with @SourabhBadhya this codepath is not get called from cleaner, because the map is obtained at 
   https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/CompactionCleaner.java#L269 
   and passed to getAcidState().
   
   Also the _acidHiddenFileFilter_ is missing from the new implementation, I guess that is the reason for at least some of the failing tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org