You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/04/18 07:24:56 UTC

[GitHub] [hadoop] aajisaka commented on a diff in pull request #4177: HDFS-16542. Fix failed unit tests in branch branch-3.2

aajisaka commented on code in PR #4177:
URL: https://github.com/apache/hadoop/pull/4177#discussion_r851940498


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java:
##########
@@ -838,7 +838,7 @@ public void testReverseXmlWithoutSnapshotDiffSection() throws Throwable {
       writer.println("<?xml version=\"1.0\"?>");
       writer.println("<fsimage>");
       writer.println("<version>");
-      writer.println("<layoutVersion>-67</layoutVersion>");
+      writer.println("<layoutVersion>-65</layoutVersion>");

Review Comment:
   The change itself is good. Would you create a separate issue and separate PR for this fix?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org