You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/12/14 13:30:00 UTC
[GitHub] [nifi] greyp9 opened a new pull request, #6781: NIFI-10980 - correct ordering of property descriptor allowable values
greyp9 opened a new pull request, #6781:
URL: https://github.com/apache/nifi/pull/6781
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 8
- [x] JDK 11
- [x] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 merged pull request #6781: NIFI-10980 - correct ordering of property descriptor allowable values
Posted by GitBox <gi...@apache.org>.
markap14 merged PR #6781:
URL: https://github.com/apache/nifi/pull/6781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #6781: NIFI-10980 - correct ordering of property descriptor allowable values
Posted by GitBox <gi...@apache.org>.
greyp9 commented on code in PR #6781:
URL: https://github.com/apache/nifi/pull/6781#discussion_r1050942965
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/pom.xml:
##########
@@ -426,5 +426,10 @@
<artifactId>nifi-mock</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-record-serialization-service-api</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Thanks! Worked fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a diff in pull request #6781: NIFI-10980 - correct ordering of property descriptor allowable values
Posted by GitBox <gi...@apache.org>.
markap14 commented on code in PR #6781:
URL: https://github.com/apache/nifi/pull/6781#discussion_r1048488426
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/pom.xml:
##########
@@ -426,5 +426,10 @@
<artifactId>nifi-mock</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-record-serialization-service-api</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Is this brought in just for this line?
```
.identifiesControllerService(RecordReaderFactory.class)
```
If so, I think we can eliminate the dependency and just use:
```
.identifiesControllerService(ControllerService.class)
```
Would like to avoid bringing an extension's api nar into framework, even for tests, if not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #6781: NIFI-10980 - correct ordering of property descriptor allowable values
Posted by GitBox <gi...@apache.org>.
markap14 commented on PR #6781:
URL: https://github.com/apache/nifi/pull/6781#issuecomment-1355201499
Thanks @greyp9 good looks good to me. +1 assuming that Github Actions complete I'll be happy to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org