You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "NoahKusaba (via GitHub)" <gi...@apache.org> on 2026/10/11 20:48:17 UTC
[PR] refactor(catalog-loader): rename CatalogBuilderFactory to BoxedCatalogBuilderFactory [iceberg-rust]
NoahKusaba opened a new pull request, #3407:
URL: https://github.com/apache/iceberg-rust/pull/3407
## Which issue does this PR close?
- No issue. Follow-up to #3286, where @comphead suggested this rename.
## What changes are included in this PR?
Renames the loader's private type alias `CatalogBuilderFactory` to `BoxedCatalogBuilderFactory`. The factories in `CATALOG_REGISTRY` return a `Box<dyn BoxedCatalogBuilder>`, not a `CatalogBuilder`, so the alias is now named after the trait it produces.
The doc comments on the alias and on `CATALOG_REGISTRY` are updated to match: the old alias doc repeated its own name, and the registry holds builder factories, not builders.
The alias is private, so there is no public API change, and `public-api.txt` is unchanged.
## Are these changes tested?
No behaviour changes, so no new tests. `cargo fmt --all -- --check`, `cargo clippy -p iceberg-catalog-loader --all-targets --all-features -- -D warnings`, `cargo test -p iceberg-catalog-loader --lib` and `cargo public-api -p iceberg-catalog-loader` (compared against `public-api.txt`) pass locally.
## AI Disclosure
- Used Claude Code to make the rename and draft this description. I reviewed the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] refactor(catalog-loader): rename CatalogBuilderFactory to BoxedCatalogBuilderFactory [iceberg-rust]
Posted by "NoahKusaba (via GitHub)" <gi...@apache.org>.
NoahKusaba commented on PR #3407:
URL: https://github.com/apache/iceberg-rust/pull/3407#issuecomment-6125461411
Seems to bit a github issue, the checks eventually passed :man_shrugging:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org