You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by zh...@gmail.com on 2010/03/01 20:33:49 UTC

Re: Introduce ConcatUriManager (issue217091)

http://codereview.appspot.com/217091/diff/2001/3001
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ConcatUriManager.java
(right):

http://codereview.appspot.com/217091/diff/2001/3001#newcode68
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ConcatUriManager.java:68:
* @param Gadget context object for the request
gadget param is gone

http://codereview.appspot.com/217091/diff/2001/3001#newcode133
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ConcatUriManager.java:133:
ValidatedUri validateConcatUri(Uri uri);
I would rename it to parse instead of validate

http://codereview.appspot.com/217091/diff/2001/3006
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUri.java
(right):

http://codereview.appspot.com/217091/diff/2001/3006#newcode30
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUri.java:30:
public static class Context {
I would rather see Context and Validate as one class.
It make it clearer for symetry of convertion to and from url.
Also easy to override

http://codereview.appspot.com/217091/show