[GitHub] [flink] tillrohrmann commented on a change in pull request #14570: [FLINK-20798][k8s] Use namespaced kubernetes client when creating FlinkKubeClient

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #14570:
URL: https://github.com/apache/flink/pull/14570#discussion_r553810024



##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClientTest.java
##########
@@ -456,6 +461,20 @@ public void testCheckAndUpdateConfigMapWhenReplaceConfigMapFailed() throws Excep
         }
     }
 
+    @Test
+    public void testWatchConfigMaps() throws Exception {
+        flinkKubeClient.watchConfigMaps(TESTING_CONFIG_MAP_NAME, new NoOpWatchCallbackHandler<>());

Review comment:
       Is it possible to use the `DefaultKubeClientFactory` here to construct a `KubeClient` which talks to the testing server? Otherwise we are testing here that the test setup initializes the testing `flinkKubeClient` with a namespace. To verify this, you could simply remove `config.setNamespace(namespace);` from `DefaultKubeClientFactory` and the test should still pass.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org