You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "YuanbenWang (via GitHub)" <gi...@apache.org> on 2023/10/23 07:38:14 UTC
[PR] HDDS-9513. Let quantiles in GrpcMetrics work normally [ozone]
YuanbenWang opened a new pull request, #5480:
URL: https://github.com/apache/ozone/pull/5480
## What changes were proposed in this pull request?
Fix some bugs about quantiles in GrpcMetrics.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9513
## How was this patch tested?
Test locally.
When config is like:
<property>
<name>ozone.grpc.metrics.percentiles.intervals</name>
<value>57</value>
</property
The result will be:
<img width="529" alt="grpc" src="https://github.com/apache/ozone/assets/48795318/47da3474-8447-4ff0-8441-5b67fd178eee">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9513. Let quantiles in GrpcMetrics work normally [ozone]
Posted by "YuanbenWang (via GitHub)" <gi...@apache.org>.
YuanbenWang commented on PR #5480:
URL: https://github.com/apache/ozone/pull/5480#issuecomment-1776412077
> It was adding to the processing time quantiles twice and skipping the queue time quantiles.
>
> Thanks @YuanbenWang for the fix. Changes LGTM!
Thank you for the review~!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9513. Fix gRPC queue time metrics [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5480:
URL: https://github.com/apache/ozone/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org