You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 10:43:40 UTC
[GitHub] [airflow] kosteev opened a new pull request, #23115: Revoke DAG specific permissions once access_control gets empty value
kosteev opened a new pull request, #23115:
URL: https://github.com/apache/airflow/pull/23115
This change is follow-up to this change https://github.com/apache/airflow/pull/15311 and https://github.com/apache/airflow/commit/3bfe0e02c2f0bb51d2740f7a9a442fa91935e8da.
Basically this change assures that DAG specific permissions are revoked once access_control field is emptied for DAG.
closes: #17508
related: #8609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #23115: Revoke DAG specific permissions once access_control gets empty value
Posted by GitBox <gi...@apache.org>.
kosteev commented on PR #23115:
URL: https://github.com/apache/airflow/pull/23115#issuecomment-1104022866
After a bit more thinking I actually realised the issue here.
The thing is that if we revoke permissions on access_control = None, that means it makes impossible to assign manually permissions on DAG resources to roles as they will be cleaned up after syncing DAG (if access_control is None).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev closed pull request #23115: Revoke DAG specific permissions once access_control gets empty value
Posted by GitBox <gi...@apache.org>.
kosteev closed pull request #23115: Revoke DAG specific permissions once access_control gets empty value
URL: https://github.com/apache/airflow/pull/23115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #23115: Revoke DAG specific permissions once access_control gets empty value
Posted by GitBox <gi...@apache.org>.
kosteev commented on PR #23115:
URL: https://github.com/apache/airflow/pull/23115#issuecomment-1103790252
@jedcunningham As you were author of related changes, please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #23115: Revoke DAG specific permissions once access_control gets empty value
Posted by GitBox <gi...@apache.org>.
kosteev commented on PR #23115:
URL: https://github.com/apache/airflow/pull/23115#issuecomment-1106108948
It might be good idea to implement this change hidden under some Airflow configuration property.
Closing pull-request as of now, for the future discussion and making decision about implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org