You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "wxbty (via GitHub)" <gi...@apache.org> on 2023/01/27 14:59:18 UTC
[GitHub] [dubbo] wxbty opened a new pull request, #11386: move metrics from common to dubbo-metrics
wxbty opened a new pull request, #11386:
URL: https://github.com/apache/dubbo/pull/11386
## What is the purpose of the change
The content of metrics should not be placed in the common package
## Brief changelog
move to dubbo-metrics，add a separate dubbo-metrics-default package, dubbo-metrics-api only needs interfaces and javabeans
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] songxiaosheng commented on pull request #11386: move metrics from common to dubbo-metrics
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on PR #11386:
URL: https://github.com/apache/dubbo/pull/11386#issuecomment-1407402170
@wxbty
Exception in thread "main" java.lang.IllegalStateException: No such extension org.apache.dubbo.metrics.service.MetricsServiceExporter by name default, no related exception was found, please check whether related SPI module is missing.
at org.apache.dubbo.common.extension.ExtensionLoader.findException(ExtensionLoader.java:760)
at org.apache.dubbo.common.extension.ExtensionLoader.createExtension(ExtensionLoader.java:767)
at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:561)
at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:535)
at org.apache.dubbo.common.extension.ExtensionLoader.getDefaultExtension(ExtensionLoader.java:587)
at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initMetricsService(DefaultApplicationDeployer.java:356)
at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initialize(DefaultApplicationDeployer.java:212)
at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.start(DefaultApplicationDeployer.java:611)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:226)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:215)
at com.apache.dubbo.demo.graalvm.consumer.Application.runWithBootstrap(Application.java:68)
at com.apache.dubbo.demo.graalvm.consumer.Application.main(Application.java:40)
Error: Process completed with exit code 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #11386: move metrics from common to dubbo-metrics
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on PR #11386:
URL: https://github.com/apache/dubbo/pull/11386#issuecomment-1407275041
@songxiaosheng PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11386: move metrics from common to dubbo-metrics
Posted by sonarcloud.
sonarcloud[bot] commented on PR #11386:
URL: https://github.com/apache/dubbo/pull/11386#issuecomment-1409719312
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=11386)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL) [82 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_coverage&view=list) [48.7% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_duplicated_lines_density&view=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11386: move metrics from common to dubbo-metrics
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ merged PR #11386:
URL: https://github.com/apache/dubbo/pull/11386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11386: move metrics from common to dubbo-metrics
Posted by sonarcloud.
sonarcloud[bot] commented on PR #11386:
URL: https://github.com/apache/dubbo/pull/11386#issuecomment-1409763313
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=11386)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL) [82 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_coverage&view=list) [48.7% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_duplicated_lines_density&view=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] wxbty commented on pull request #11386: move metrics from common to dubbo-metrics
Posted by "wxbty (via GitHub)" <gi...@apache.org>.
wxbty commented on PR #11386:
URL: https://github.com/apache/dubbo/pull/11386#issuecomment-1408128696
> pull_request
done, there is another ci [ubuntu-latest] failure, no reason can be seen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] wxbty commented on pull request #11386: move metrics from common to dubbo-metrics
Posted by "wxbty (via GitHub)" <gi...@apache.org>.
wxbty commented on PR #11386:
URL: https://github.com/apache/dubbo/pull/11386#issuecomment-1407424549
> @wxbty Exception in thread "main" java.lang.IllegalStateException: No such extension org.apache.dubbo.metrics.service.MetricsServiceExporter by name default, no related exception was found, please check whether related SPI module is missing. at org.apache.dubbo.common.extension.ExtensionLoader.findException(ExtensionLoader.java:760) at org.apache.dubbo.common.extension.ExtensionLoader.createExtension(ExtensionLoader.java:767) at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:561) at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:535) at org.apache.dubbo.common.extension.ExtensionLoader.getDefaultExtension(ExtensionLoader.java:587) at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initMetricsService(DefaultApplicationDeployer.java:356) at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initialize(DefaultApplicationDeployer.java:212) at org.apache.dubbo.config.deploy.DefaultApplicationDe
ployer.start(DefaultApplicationDeployer.java:611) at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:226) at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:215) at com.apache.dubbo.demo.graalvm.consumer.Application.runWithBootstrap(Application.java:68) at com.apache.dubbo.demo.graalvm.consumer.Application.main(Application.java:40) Error: Process completed with exit code 1.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11386: move metrics from common to dubbo-metrics
Posted by sonarcloud.
sonarcloud[bot] commented on PR #11386:
URL: https://github.com/apache/dubbo/pull/11386#issuecomment-1407595790
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=11386)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL) [82 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_coverage&view=list) [49.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_duplicated_lines_density&view=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #11386: move metrics from common to dubbo-metrics
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on PR #11386:
URL: https://github.com/apache/dubbo/pull/11386#issuecomment-1408044136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #11386: move metrics from common to dubbo-metrics
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11386:
URL: https://github.com/apache/dubbo/pull/11386#issuecomment-1407596196
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11386](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7bc70a8) into [3.2](https://codecov.io/gh/apache/dubbo/commit/10030010a65d3f1fb30d3dd3b23d572dc645a500?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1003001) will **decrease** coverage by `3.73%`.
> The diff coverage is `20.00%`.
```diff
@@ Coverage Diff @@
## 3.2 #11386 +/- ##
============================================
- Coverage 68.54% 64.81% -3.73%
+ Complexity 127 14 -113
============================================
Files 1445 1498 +53
Lines 74154 62502 -11652
Branches 12653 9146 -3507
============================================
- Hits 50826 40509 -10317
+ Misses 18690 17759 -931
+ Partials 4638 4234 -404
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `72.23% <ø> (-5.43%)` | :arrow_down: |
| [...o/config/deploy/DefaultMetricsServiceExporter.java](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1ldHJpY3NTZXJ2aWNlRXhwb3J0ZXIuamF2YQ==) | `79.48% <ø> (ø)` | |
| [...a/org/apache/dubbo/metrics/event/MetricsEvent.java](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9ldmVudC9NZXRyaWNzRXZlbnQuamF2YQ==) | `57.14% <ø> (ø)` | |
| [...n/java/org/apache/dubbo/metrics/event/RTEvent.java](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9ldmVudC9SVEV2ZW50LmphdmE=) | `66.66% <ø> (ø)` | |
| [...a/org/apache/dubbo/metrics/event/RequestEvent.java](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9ldmVudC9SZXF1ZXN0RXZlbnQuamF2YQ==) | `86.66% <ø> (ø)` | |
| [...a/org/apache/dubbo/metrics/model/MethodMetric.java](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9tb2RlbC9NZXRob2RNZXRyaWMuamF2YQ==) | `67.56% <ø> (ø)` | |
| [...rg/apache/dubbo/metrics/model/MetricsCategory.java](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9tb2RlbC9NZXRyaWNzQ2F0ZWdvcnkuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ava/org/apache/dubbo/metrics/model/MetricsKey.java](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9tb2RlbC9NZXRyaWNzS2V5LmphdmE=) | `100.00% <ø> (ø)` | |
| [.../dubbo/metrics/model/sample/GaugeMetricSample.java](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9tb2RlbC9zYW1wbGUvR2F1Z2VNZXRyaWNTYW1wbGUuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...pache/dubbo/metrics/model/sample/MetricSample.java](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0cmljcy9kdWJiby1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbWV0cmljcy9tb2RlbC9zYW1wbGUvTWV0cmljU2FtcGxlLmphdmE=) | `52.38% <ø> (ø)` | |
| ... and [599 more](https://codecov.io/gh/apache/dubbo/pull/11386?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11386: move metrics from common to dubbo-metrics
Posted by sonarcloud.
sonarcloud[bot] commented on PR #11386:
URL: https://github.com/apache/dubbo/pull/11386#issuecomment-1409674575
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=11386)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11386&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL) [82 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11386&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_coverage&view=list) [48.8% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_duplicated_lines_density&view=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11386&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org