You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "wmedvede (via GitHub)" <gi...@apache.org> on 2024/12/13 09:50:31 UTC

[PR] NO-ISSUE: Use the SonataFlow icon in the nav bar [incubator-kie-kogito-docs]

wmedvede opened a new pull request, #694:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/694

   <!-- Please don't forget your Issue link -->
   
   <!-- Please provide a short description of what this PR does -->
   **Description:**
   
   <!-- Link to related PRs: -->
   
   Please make sure that your PR meets the following requirements:
   
   - [X] You have read the [contributions doc](https://github.com/apache/incubator-kie-kogito-docs/blob/main/CONTRIBUTING.md)
   - [X] Pull Request title is properly formatted: `Issue-XYZ Subject`
   - [X] Pull Request title contains the target branch if not targeting main: `[0.9.x] Issue-XYZ Subject`
   - [X] The nav.adoc file has a link to this guide in the proper category
   - [X] The index.adoc file has a card to this guide in the proper category, with a meaningful description
   
   <details>
   <summary>
   How to backport a pull request to a different branch?
   </summary>
   
   In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-<branch-name>`, where `<branch-name>` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch).
   
   > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.
   
   Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
   
   If something goes wrong, the author will be notified and at this point a manual backporting is needed.
   
   > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Use the SonataFlow icon in the nav bar [incubator-kie-kogito-docs]

Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede commented on PR #694:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/694#issuecomment-2545591893

   > Pretty cool, @wmedvede!! I liked the option four the most. wdyt?
   
   great! thanks for voting.
   If you don't mind, I'll add your vote for the proposal 4 in the poll!.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Use the SonataFlow icon in the nav bar [incubator-kie-kogito-docs]

Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #694:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/694#issuecomment-2542019815

   Pretty cool, @wmedvede!! I liked the option four the most. wdyt?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Use the SonataFlow icon in the nav bar [incubator-kie-kogito-docs]

Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede commented on PR #694:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/694#issuecomment-2559091388

   The final proposals where:
   ![Proposal1_better_icon_Screenshot from 2024-12-17 11-33-15](https://github.com/user-attachments/assets/f5c8e6a4-fe7f-4cfe-a707-0a1044903537)
   and
   ![Proposal3_better_icon_Screenshot from 2024-12-17 11-37-26](https://github.com/user-attachments/assets/e6129e04-4ba0-4efc-b34b-f86438ee0e3d)
   
   Finally,  Proposal1 winned


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Use the SonataFlow icon in the nav bar [incubator-kie-kogito-docs]

Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede commented on PR #694:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/694#issuecomment-2541832894

   Here goes guys a screenshot of each proposal for comparison:
   
   ![Proposal_1_Screenshot from 2024-12-13 17-27-41](https://github.com/user-attachments/assets/e9b8d6db-98f7-41e6-8a17-dfb09bec8dd4)
   
   
   ![Proposal_2_Screenshot from 2024-12-13 17-10-47](https://github.com/user-attachments/assets/a395ec40-dead-48c1-821d-5e3601efaded)
   
   
   ![Proposal_3_Screenshot from 2024-12-13 17-15-48](https://github.com/user-attachments/assets/52fe81ef-d291-4c8b-a612-97464b9fc1da)
   
   
   ![Proposal_4_Screenshot from 2024-12-13 17-19-04](https://github.com/user-attachments/assets/4f518ddf-dc81-4558-8067-cbe008080a49)
   
   
   
   ![Proposal_5_Screenshot from 2024-12-13 17-21-38](https://github.com/user-attachments/assets/d73aebd2-85cb-4c06-8067-a0d35913545e)
   
   
   ![Proposal_6_Screenshot from 2024-12-13 17-24-14](https://github.com/user-attachments/assets/b995353f-5644-4581-9682-8d5d98d4a511)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Use the SonataFlow icon in the nav bar [incubator-kie-kogito-docs]

Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede merged PR #694:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/694


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Use the SonataFlow icon in the nav bar [incubator-kie-kogito-docs]

Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede commented on PR #694:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/694#issuecomment-2547915291

   I have incorporated the white circled icon kindly provided by @masha.
   With or without any background color change, I think we must add it.
   
   Examples here:
   
   ![image (13)](https://github.com/user-attachments/assets/509ef8bc-0487-4f82-8c44-1742dc887edc)
   
   
   ![image (14)](https://github.com/user-attachments/assets/21091e52-7b0e-4639-8ed3-21ae7d6ecce0)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Use the SonataFlow icon in the nav bar [incubator-kie-kogito-docs]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #694:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/694#issuecomment-2541022462

   🎊 PR Preview ea1866dbe87d6aece98047a511d017d19a2fb0cb has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-694.surge.sh
   <!-- Sticky Pull Request Comment -->
   <!-- Sticky Pull Request Comment -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Use the SonataFlow icon in the nav bar [incubator-kie-kogito-docs]

Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #694:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/694#discussion_r1884079339


##########
antora/supplemental-ui/css/navbar.css:
##########
@@ -1,3 +1,3 @@
 .navbar {
-    background: #085870 !important;
+    background: #0476d0 !important;

Review Comment:
   @wmedvede can you try one of these colors and see which one matches better?
   
   > Deep Navy Blue (#002F5F) – A dark blue that matches the logo's darker tones, providing a professional and elegant look.
   
   > Teal Blue (#007E99) – A slightly lighter shade of blue to complement the lighter parts of the logo and create a fresh, modern vibe.
   
   > Charcoal Black (#1C1C1C) – A neutral and bold black that can make the logo stand out while maintaining simplicity.
   
   > Soft Orange (#F4A261) – A muted orange that aligns with the logo’s orange wave, creating a warm and inviting feel.
   
   > Cool Gray (#E0E0E0) – A neutral light gray that contrasts the logo without overshadowing it, ideal for a clean design.
   
   AI suggested it based on our colors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org