You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/11/24 17:30:36 UTC

[GitHub] [httpcomponents-client] arturobernalg edited a comment on pull request #329: WIP: Use Time APIs for date in the Request.java and Warning value.

arturobernalg edited a comment on pull request #329:
URL: https://github.com/apache/httpcomponents-client/pull/329#issuecomment-974892215


   > @arturobernalg
   > 
   > 1. Please do not feed your changes piecemeal. Work on a branch and raise a PR once _everything_ is ready. If you need help or another pair of eyeballs, ask people to look at the code in your branch
   > 2. Only public classes need to remain backward compatible. Private and package private classes can be changed without deprecation and `@since` metadata.
   > 3. If you are concerned about breaking existing functionality, create a test case with old APIs, make sure it works, then port it to the new APIs.
   
   HI @ok2c 
   Fair enough. I change the [PR](https://github.com/apache/httpcomponents-client/pull/330) to draft until I change all the api.
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org