You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/03/18 00:57:41 UTC

[kudu-CR] kudu-spark: switch default profile from spark1/2.10 to spark2/2.11

Hello Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/6420

to review the following change.

Change subject: kudu-spark: switch default profile from spark1/2.10 to spark2/2.11
......................................................................

kudu-spark: switch default profile from spark1/2.10 to spark2/2.11

Now that we have kudu-spark-tools which only works with Spark2, it's
probably best if developers are defaulted to running tests with Spark2.
This shouldn't affect CI or published artifacts.

Change-Id: Idf57e99890bd413a678e275af55b9c6315edf917
---
M build-support/jenkins/build-and-test.sh
M java/pom.xml
2 files changed, 13 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/6420/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf57e99890bd413a678e275af55b9c6315edf917
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>

[kudu-CR] kudu-spark: switch default profile from spark1/2.10 to spark2/2.11

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: kudu-spark: switch default profile from spark1/2.10 to spark2/2.11
......................................................................


kudu-spark: switch default profile from spark1/2.10 to spark2/2.11

Now that we have kudu-spark-tools which only works with Spark2, it's
probably best if developers are defaulted to running tests with Spark2.
This shouldn't affect CI or published artifacts.

Change-Id: Idf57e99890bd413a678e275af55b9c6315edf917
Reviewed-on: http://gerrit.cloudera.org:8080/6420
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M build-support/jenkins/build-and-test.sh
M java/pom.xml
2 files changed, 14 insertions(+), 14 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf57e99890bd413a678e275af55b9c6315edf917
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] kudu-spark: switch default profile from spark1/2.10 to spark2/2.11

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: kudu-spark: switch default profile from spark1/2.10 to spark2/2.11
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf57e99890bd413a678e275af55b9c6315edf917
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] kudu-spark: switch default profile from spark1/2.10 to spark2/2.11

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: kudu-spark: switch default profile from spark1/2.10 to spark2/2.11
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf57e99890bd413a678e275af55b9c6315edf917
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] kudu-spark: switch default profile from spark1/2.10 to spark2/2.11

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6420

to look at the new patch set (#3).

Change subject: kudu-spark: switch default profile from spark1/2.10 to spark2/2.11
......................................................................

kudu-spark: switch default profile from spark1/2.10 to spark2/2.11

Now that we have kudu-spark-tools which only works with Spark2, it's
probably best if developers are defaulted to running tests with Spark2.
This shouldn't affect CI or published artifacts.

Change-Id: Idf57e99890bd413a678e275af55b9c6315edf917
---
M build-support/jenkins/build-and-test.sh
M java/pom.xml
2 files changed, 14 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/6420/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf57e99890bd413a678e275af55b9c6315edf917
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins