You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jason810496 (via GitHub)" <gi...@apache.org> on 2024/11/30 06:33:14 UTC
[PR] Remove AIP-44 from models/skipmixin [airflow]
jason810496 opened a new pull request, #44503:
URL: https://github.com/apache/airflow/pull/44503
related: https://github.com/apache/airflow/issues/44436
- [x] ./airflow/models/skipmixin.py: _skip
- [x] ./airflow/models/skipmixin.py: _skip_all_except
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIP-44 from models/skipmixin [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #44503:
URL: https://github.com/apache/airflow/pull/44503#issuecomment-2510223027
(we are CLOSE) :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIP-44 from models/skipmixin [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #44503:
URL: https://github.com/apache/airflow/pull/44503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIP-44 from models/skipmixin [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #44503:
URL: https://github.com/apache/airflow/pull/44503#issuecomment-2510222933
Resolved conflicts :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIP-44 from models/skipmixin [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #44503:
URL: https://github.com/apache/airflow/pull/44503#discussion_r1864288252
##########
airflow/models/skipmixin.py:
##########
@@ -94,26 +93,13 @@ def _set_state_to_skipped(
.execution_options(synchronize_session=False)
)
+ @provide_session
Review Comment:
We can remove all ` | ...Pydantic` references in this one as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIP-44 from models/skipmixin [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #44503:
URL: https://github.com/apache/airflow/pull/44503#discussion_r1864993955
##########
airflow/models/skipmixin.py:
##########
@@ -94,26 +93,13 @@ def _set_state_to_skipped(
.execution_options(synchronize_session=False)
)
+ @provide_session
Review Comment:
Later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org