Re: [I] Make KMS key generation configurable for AwsKeyManagementClient and AliyunKeyManagementClient (currently always wraps) [iceberg]

["abhishekmauryaKsolves (via GitHub)" <gi...@apache.org>]

abhishekmauryaKsolves commented on issue #18300:
URL: https://github.com/apache/iceberg/issues/18300#issuecomment-5903616210

   Hi, I'd like to work on the AWS part of this. My plan: add a config property (e.g. kms.client.aws.key-generation-enabled) read in AwsKeyManagementClient.initialize() and use it in supportsKeyGeneration(). Two questions: (1) what should the property name and default be? #18210 uses kms.client.aliyun.key.generation.enabled with default true, but keeping false would preserve current AWS behavior. (2) Should Aliyun be handled in #18210 or as a follow-up after it merges?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org