You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2026/06/14 13:35:09 UTC
[GH] (pekko/durable-state-runtime-config): Workflow run "Pull Requests" is working again!
The GitHub Actions job "Pull Requests" on pekko.git/durable-state-runtime-config has succeeded.
Run started by GitHub user ptrdom (triggered by ptrdom).
Head commit for run:
dbbc764648a9345cb01b10bc645087536913c308 / Domantas Petrauskas <do...@gmail.com>
Address review for DurableState runtime config
Motivation:
Review feedback on PR #3058: the runtime `pluginConfig` parameter shadowed
the private `pluginConfig(pluginId)` method, and the new runtime plugin
configuration feature was only covered by a Scala spec.
Modification:
Rename the runtime `Config` parameter to `runtimeConfig` in
`durableStateStoreFor`/`getDurableStateStoreFor` to avoid shadowing, and add
a Java DSL `RuntimeDurableStateStoreTest` mirroring the Scala spec to keep
the Scala and Java DSLs in test parity.
Result:
No name collision with the private method, and the Java DSL runtime plugin
config and `getDurableStateStoreFor(clazz, pluginId, config)` are covered.
Tests:
- sbt "persistence-typed-tests/Test/testOnly org.apache.pekko.persistence.typed.state.javadsl.RuntimeDurableStateStoreTest" - Passed 1
- sbt "persistence-typed-tests/Test/javafmtCheck" (JDK 17) - success
- sbt "persistence-typed-tests/headerCheckAll" - success
References:
Refs #3058
Report URL: https://github.com/apache/pekko/actions/runs/27499989896
With regards,
GitHub Actions via GitBox
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org