You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/10 05:09:08 UTC
[PR] test(nameserver): pin the nameserver delete contract [rocketmq-dashboard]
zjncs opened a new pull request, #6037:
URL: https://github.com/apache/rocketmq-dashboard/pull/6037
### What
`DeleteNameServerDTO` carries a NameServer removal. It had no dedicated test (only indirect use in controller tests). This adds 3 tests.
### What is pinned
- a valid request passes untouched;
- **the cluster is required** and **the address is required** — a request that fails validation must never fall through to deleting an arbitrary node.
### Verification
- New tests on unmodified code: **3/3 green**, checkstyle clean.
- Discriminating mutation: the `clusterId` constraint message drifted (red).
- Restored: 3/3 green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org