Re: [PR] Draft: XERCESJ-1771 - Code complete on location info feature. Can't get Junit tests working tho. Help Plz. [xerces-j]

["mbeckerle (via GitHub)" <gi...@apache.org>]

mbeckerle commented on code in PR #7:
URL: https://github.com/apache/xerces-j/pull/7#discussion_r1962452413


##########
src/org/apache/xerces/dom/NodeImpl.java:
##########
@@ -145,6 +146,8 @@ public abstract class NodeImpl
     // Data
     //
 
+    public Locator locator;

Review Comment:
   Revert. This change not needed. This file needs no modification. 



##########
src/org/apache/xerces/impl/XML11NSDocumentScannerImpl.java:
##########
@@ -130,6 +132,20 @@ protected boolean scanStartElement() throws IOException, XNIException {
 
         // Note: namespace processing is on by default
         fEntityScanner.scanQName(fElementQName);
+

Review Comment:
   There is almost the same code in this class and in the XMLDocumentFragmentScanner. 
   I hate duplicating code.
   
   Is it needed in both places if it is to work with XML 1.0 and XML 1.1 ? Is there a sensible place to factor it out?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org