You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/29 02:24:02 UTC

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource

nsivabalan commented on code in PR #7086:
URL: https://github.com/apache/hudi/pull/7086#discussion_r1008610920


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsSource.java:
##########
@@ -79,6 +81,13 @@ public Pair<Option<Dataset<Row>>, String> fetchNextBatch(Option<String> lastCkpt
     }
   }
 
+  @Override
+  public void close() throws IOException {
+    // close resource
+    this.sqs.shutdown();
+

Review Comment:
   remove extra lines. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org