[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1017: Align the expire option behavior of redis

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #1017:
URL: https://github.com/apache/incubator-kvrocks/pull/1017#discussion_r1001942133


##########
tests/gocase/unit/type/strings/strings_test.go:
##########
@@ -497,7 +573,12 @@ func TestString(t *testing.T) {
 	})
 
 	t.Run("Extended SET with incorrect use of multi options should result in syntax err", func(t *testing.T) {
-		require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar", "ex", "10", "px", "10000").Err(), "syntax err")

Review Comment:
   You can still retain this case? Although it's semantically equal to `px 100 ex 10`, we're testing the parsing logic here so `ex 10 px 10000` can be a different case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org