[GitHub] [spark] cloud-fan commented on a change in pull request #31455: [SPARK-34342][SQL] Format DateLiteral and TimestampLiteral toString

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31455:
URL: https://github.com/apache/spark/pull/31455#discussion_r569550410



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -298,11 +298,21 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
   override def foldable: Boolean = true
   override def nullable: Boolean = value == null
 
+  private val timeZoneId = DateTimeUtils.getZoneId(SQLConf.get.sessionLocalTimeZone)

Review comment:
       shall we use `def`? we don't need to serialize it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org