You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "remicollet (via GitHub)" <gi...@apache.org> on 2026/09/02 10:17:05 UTC
[PR] Constify to fix build with OpenSSL 4 [cassandra-cpp-driver]
remicollet opened a new pull request, #590:
URL: https://github.com/apache/cassandra-cpp-driver/pull/590
Without this patch, with OpenSSL 4 (on Fedora 45)
```
tity::Result OpenSslVerifyIdentity::match_common_name_ipaddr(X509*, const datastax::String&)’:
/builddir/build/BUILD/cassandra-cpp-driver-2.17.1-build/cpp-driver-e05897d72fdac08a212ed3136b7790232670e329/src/ssl/ssl_openssl_impl.cpp:285:44: error: invalid conversion from ‘const X509_NAME*’ {aka ‘const X509_name_st*’} to ‘X509_NAME*’ {aka ‘X509_name_st*’} [-Werror=permissive]
285 | X509_NAME* name = X509_get_subject_name(cert);
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~
| |
| const X509_NAME* {aka const X509_name_st*}
/builddir/build/BUILD/cassandra-cpp-driver-2.17.1-build/cpp-driver-e05897d72fdac08a212ed3136b7790232670e329/src/ssl/ssl_openssl_impl.cpp:292:56: error: invalid conversion from ‘const X509_NAME_ENTRY*’ {aka ‘const X509_name_entry_st*’} to ‘X509_NAME_ENTRY*’ {aka ‘X509_name_entry_st*’} [-Werror=permissive]
292 | X509_NAME_ENTRY* name_entry = X509_NAME_get_entry(name, i);
| ~~~~~~~~~~~~~~~~~~~^~~~~~~~~
| |
| const X509_NAME_ENTRY* {aka const X509_name_entry_st*}
/builddir/build/BUILD/cassandra-cpp-driver-2.17.1-build/cpp-driver-e05897d72fdac08a212ed3136b7790232670e329/src/ssl/ssl_openssl_impl.cpp:297:50: error: invalid conversion from ‘const ASN1_STRING*’ {aka ‘const asn1_string_st*’} to ‘ASN1_STRING*’ {aka ‘asn1_string_st*’} [-Werror=permissive]
297 | ASN1_STRING* str = X509_NAME_ENTRY_get_data(name_entry);
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
| |
| const ASN1_STRING* {aka const asn1_string_st*}
/builddir/build/BUILD/cassandra-cpp-driver-2.17.1-build/cpp-driver-e05897d72fdac08a212ed3136b7790232670e329/src/ssl/ssl_openssl_impl.cpp: In static member function ‘static OpenSslVerifyIdentity::Result OpenSslVerifyIdentity::match_common_name_dns(X509*, const datastax::String&)’:
/builddir/build/BUILD/cassandra-cpp-driver-2.17.1-build/cpp-driver-e05897d72fdac08a212ed3136b7790232670e329/src/ssl/ssl_openssl_impl.cpp:316:44: error: invalid conversion from ‘const X509_NAME*’ {aka ‘const X509_name_st*’} to ‘X509_NAME*’ {aka ‘X509_name_st*’} [-Werror=permissive]
316 | X509_NAME* name = X509_get_subject_name(cert);
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~
| |
| const X509_NAME* {aka const X509_name_st*}
/builddir/build/BUILD/cassandra-cpp-driver-2.17.1-build/cpp-driver-e05897d72fdac08a212ed3136b7790232670e329/src/ssl/ssl_openssl_impl.cpp:323:56: error: invalid conversion from ‘const X509_NAME_ENTRY*’ {aka ‘const X509_name_entry_st*’} to ‘X509_NAME_ENTRY*’ {aka ‘X509_name_entry_st*’} [-Werror=permissive]
323 | X509_NAME_ENTRY* name_entry = X509_NAME_get_entry(name, i);
| ~~~~~~~~~~~~~~~~~~~^~~~~~~~~
| |
| const X509_NAME_ENTRY* {aka const X509_name_entry_st*}
/builddir/build/BUILD/cassandra-cpp-driver-2.17.1-build/cpp-driver-e05897d72fdac08a212ed3136b7790232670e329/src/ssl/ssl_openssl_impl.cpp:328:50: error: invalid conversion from ‘const ASN1_STRING*’ {aka ‘const asn1_string_st*’} to ‘ASN1_STRING*’ {aka ‘asn1_string_st*’} [-Werror=permissive]
328 | ASN1_STRING* str = X509_NAME_ENTRY_get_data(name_entry);
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
| |
| const ASN1_STRING* {aka const asn1_string_st*}
cc1plus: all warnings being treated as errors
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Constify to fix build with OpenSSL 4 [cassandra-cpp-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce merged PR #590:
URL: https://github.com/apache/cassandra-cpp-driver/pull/590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Constify to fix build with OpenSSL 4 [cassandra-cpp-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #590:
URL: https://github.com/apache/cassandra-cpp-driver/pull/590#issuecomment-5532917754
Seems legit to me. Triggered a Jenkins run just to confirm that there aren't any unintended consequences here (although I can't imagine what they'd be)... that run looked good.
Relevant change seems to be [here](https://github.com/openssl/openssl/commit/b0f2107b44049805b39434d104c8bb0daf8ae079).
@yifan-c Any objections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Constify to fix build with OpenSSL 4 [cassandra-cpp-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #590:
URL: https://github.com/apache/cassandra-cpp-driver/pull/590#issuecomment-5593131180
Thanks for the fix @remicollet!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Constify to fix build with OpenSSL 4 [cassandra-cpp-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #590:
URL: https://github.com/apache/cassandra-cpp-driver/pull/590#issuecomment-5593097451
There's not a ticket for it @yifan-c. The _preference_ is for JIRA tickets whenever possible but they aren't required. If we're adding a new feature they're usually a pretty good idea but for smaller changes like this one I haven't been requiring a ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org