[jira] [Commented] (ARTEMIS-1958) Artemis may not be able to delete pages when there are some empty page files

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527164#comment-16527164 ] 

ASF GitHub Bot commented on ARTEMIS-1958:
-----------------------------------------

Github user morefuntang commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2166
  
    **Added test case.**
    
    Description:
    Due to certain customization features may cause some page files to be empty. When all messages in the Page file are consumed, expired Page files should be deleted.
    But in fact, the Page files have not been deleted.
    the list of page files is as follows:
    
    **rw-rr- 1 artemis activemq 0 Jun 28 15:38 000000003.page
    rw-rr- 1 artemis activemq 0 Jun 28 15:38 000000004.page**
    rw-rr- 1 artemis activemq 10485215 Jun 28 15:38 000000005.page
    rw-rr- 1 artemis activemq 10485215 Jun 28 15:38 000000006.page
    rw-rr- 1 artemis activemq 10485215 Jun 28 15:39 000000007.page
    rw-rr- 1 artemis activemq 10485215 Jun 28 15:39 000000008.page
    rw-rr- 1 artemis activemq 3813259 Jun 28 15:39 000000009.page
    **rw-rr- 1 artemis activemq 0 Jun 28 15:39 000000010.page
    rw-rr- 1 artemis activemq 0 Jun 28 15:39 000000011.page**
    
    In the current scene, the File with Page size 0 is not in ConsumedPages, causing PageCursorProvider not find the empty page file when cleanup.
    When trying to put an empty file into the consumedPage, PageCursorProvider can successfully delete the empty page file


> Artemis may not be able to delete pages when there are some empty page files
> ----------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1958
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1958
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.6.2
>            Reporter: tang pu
>            Priority: Minor
>
> Due to certain customization features may cause some page files to be empty.
> the list of page files is as follows:
> -rw-r--r-- 1 artemis activemq *{color:#FF0000}0{color}* Jun 28 15:38 000000003.page
> -rw-r--r-- 1 artemis activemq *{color:#FF0000}0{color}* Jun 28 15:38 000000004.page
> -rw-r--r-- 1 artemis activemq 10485215 Jun 28 15:38 000000005.page
> -rw-r--r-- 1 artemis activemq 10485215 Jun 28 15:38 000000006.page
> -rw-r--r-- 1 artemis activemq 10485215 Jun 28 15:39 000000007.page
> -rw-r--r-- 1 artemis activemq 10485215 Jun 28 15:39 000000008.page
> -rw-r--r-- 1 artemis activemq 3813259 Jun 28 15:39 000000009.page
> -rw-r--r-- 1 artemis activemq *{color:#FF0000}0{color}* Jun 28 15:39 000000010.page
> -rw-r--r-- 1 artemis activemq{color:#FF0000} *0*{color} Jun 28 15:39 000000011.page
> When all messages in the Page file are consumed, expired Page files should be deleted.
> But in fact, the Page files have not been deleted.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)